Remove direct type comparisons

[Zhongyue Luo]

Type comparisons should use isinstance with built-in factory functions.

Use "if not isinstance(items, list)" rather than "if not isinstance(items, types.ListType)"

[Zhongyue Luo (zyluo)]

http://docs.python.org/library/types.html

[Zhongyue Luo (zyluo)]

According to PEP8,

- Object type comparisons should always use isinstance() instead
      of comparing types directly.

        Yes: if isinstance(obj, int):

        No: if type(obj) is type(1):

      When checking if an object is a string, keep in mind that it might be a
      unicode string too! In Python 2.3, str and unicode have a common base
      class, basestring, so you can do:

        if isinstance(obj, basestring):

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/2729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/2729
Committed: http://github.com/openstack/nova/commit/ae1654bc5910dba5f02f49bc57a49442b9a5f8d6
Submitter: Jenkins
Branch: master

commit ae1654bc5910dba5f02f49bc57a49442b9a5f8d6
Author: lzyeval <email address hidden>
Date: Mon Jan 2 17:31:36 2012 +0800

    PEP8 remove direct type comparisons

    Fixes bug #910763

    According to PEP8,
    - Object type comparisons should always use isinstance() instead
          of comparing types directly.

            Yes: if isinstance(obj, int):

            No: if type(obj) is type(1):

          When checking if an object is a string, keep in mind that it might be a
          unicode string too! In Python 2.3, str and unicode have a common base
          class, basestring, so you can do:

            if isinstance(obj, basestring):

    Change-Id: I7c0fdecf99872f5b8f72b2c2ed4f5c539c33def1