QuantumManager#get_all_networks uninitalized variable

Bug #901459 reported by Aaron Lee on 2011-12-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Brad Hall

Bug Description

In QuantumManager's get_all_networks project_id does not exist(the last argument to networks.extend()). It should be p.id. This also needs to be tested. I +1ed the commit without noticing this, so I'll devise a punishment for myself then get a patch together.

dan wendlandt (danwent) wrote :

sounds like we need some better coverage in unit tests for QuantumManager as well. I'll take some blame for that :)

Brad Hall (bgh) wrote :

I'll take the rest of the blame :) We'll be adding more tests very soon..

Changed in nova:
assignee: nobody → Brad Hall (bgh)
status: New → In Progress

Reviewed: https://review.openstack.org/2161
Committed: http://github.com/openstack/nova/commit/35782f24fa50b5b96072f9b81128f352098d50af
Submitter: Jenkins
Branch: master

 status fixcommitted

commit 35782f24fa50b5b96072f9b81128f352098d50af
Author: Brad Hall <email address hidden>
Date: Wed Dec 7 23:31:50 2011 +0000

    Fix for bug 901459

    Fix cut and paste error: change project_id to p['id'] as project_id
    doesn't exist in this scope.

    Also added project creation to the unit test which would have caught

    Change-Id: I1bd53265e3d622a59969eb286c3fbde471374c73

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2011-12-14
Changed in nova:
milestone: none → essex-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers