"nova actions" fails with HTTP 400 / TypeError if a server action has been performed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| OpenStack Compute (nova) |
Medium
|
Ewan Mellor | ||
| Diablo |
Undecided
|
Unassigned |
Bug Description
"nova actions 1" (where credentials are set and 1 is a valid server ID) with an HTTP 400 error and TypeError: 'dict' object is not callable in the nova-api logs, iff there has been a previous call to the /servers/%s/action handler (such as "nova reboot 1").
The problem is that Controller.action sets self.actions to a dictionary, which overwrites the definition of the Controller.actions method.
Changed in nova: | |
status: | New → In Progress |
assignee: | nobody → Ewan Mellor (ewanmellor) |
Ewan Mellor (ewanmellor) wrote : | #1 |
Changed in nova: | |
importance: | Undecided → Medium |
milestone: | none → essex-2 |
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
status fixcommitted
done
commit 4a76167e354eed4
Author: Ewan Mellor <email address hidden>
Date: Sun Nov 27 23:26:49 2011 -0800
Bug #897091: "nova actions" fails with HTTP 400 / TypeError if a server action has been performed
Fix code in Controller.action that was overwriting the definition of the
actions method with a dictionary. This meant that 'nova actions' would fail
if 'nova reboot' had previously been called.
Added two tests, one for the actions call in general, and one for this
failure mode specifically.
Change-Id: I695bb5c4dcfba9
Changed in nova: | |
status: | In Progress → Fix Committed |
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: stable/diablo
tag in-stable-diablo
done
commit c733462b2292902
Author: Ewan Mellor <email address hidden>
Date: Sun Nov 27 23:26:49 2011 -0800
Bug #897091: "nova actions" fails with HTTP 400 / TypeError if a server action has been performed
Fix code in Controller.action that was overwriting the definition of the
actions method with a dictionary. This meant that 'nova actions' would fail
if 'nova reboot' had previously been called.
Added two tests, one for the actions call in general, and one for this
failure mode specifically.
(cherry picked from commit 4a76167e354eed4
Change-Id: I695bb5c4dcfba9
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | essex-2 → 2012.1 |
https:/ /review. openstack. org/1915