| 2011-11-17 19:07:27 |
Chris Behrens |
description |
_live_migration_common_check tries to catch exception.NotFileFound when trying to do rpc.call()s... but rpc.call() will only ever raise a RemoteError. If you "except RemoteError, err", you can check err.exc_type for the original exception class name... but I don't see where exception.FileNotFound ever gets raised on the worker side (compute manager).
I'm refactoring scheduler tests and found this. Since I don't know what the intended behavior is for the above, I can't fix it myself. I'll leave comments in my refactoring referencing this bug id. |
_live_migration_common_check tries to catch exception.NotFileFound when trying to do rpc.call()s... but something feels wrong here.
I'm refactoring scheduler tests and found this, but I don't know the intended behavior. The code around mounted_on_same_shared_storage() is confusing and doesn't seem quite right. I don't see why we raise NotFileFound only to catch it in the caller... instead of just checking the result of the calling function. Also good to note: If an exception occurs in compute manager's 'create_shared_storage_test_file', the rpc.call to it will not re-raise the original exception. rpc.common.RemoteError will end up being raised on the calling side. I could see 'create_shared_storage_test_file' failing with OSError if the dir doesn't exist, etc...
I'm noting this bug ID in the code w/ my refactor for someone else to take a look at. |
|
