OpenStack Compute (Nova)

multistring flags do not parse properly

Reported by Vish Ishaya on 2011-11-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Mark McLoughlin

Bug Description

The switch from gflags broke multistring parsing. There are two issues:

a) default values are not overridden

b) any value specified in a flagfile is appended multiple times (it appears to be each time the flags are reparsed)

for example, specifying --osapi_extension=extensions.admin.Admin leads to:

2011-11-14 23:45:12,183 DEBUG nova [-] osapi_extension : ['nova.api.openstack.contrib.standard_extensions', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admi
n.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extension
s.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'ext
ensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin'
, 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.
Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.
admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'exten
sions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin',
'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Ad
min', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.ad
min.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensi
ons.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'e
xtensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admi
n', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admi
n.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin', 'extension
s.admin.Admin', 'extensions.admin.Admin', 'extensions.admin.Admin'] from (pid=11909) wait /opt/stack/nova/nova/service.py:383

expected output:

2011-11-14 23:45:12,183 DEBUG nova [-] osapi_extension : ['extensions.admin.Admin'] from (pid=11909) wait /opt/stack/nova/nova/service.py:383

(i.e. you should have to reiterate the default value for it to load)

Changed in nova:
importance: Undecided → Low
assignee: nobody → Mark McLoughlin (markmc)
status: New → Triaged
Changed in nova:
status: Triaged → Fix Committed
Thierry Carrez (ttx) on 2011-12-14
Changed in nova:
milestone: none → essex-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers