Some keypair-related unit tests fail on RHEL6.1

[Lorin Hochstein]

Some unit tests related to keypairs fail on RHEL6.1:

CloudTestCase
    test_delete_key_pair ERROR
    test_describe_key_pairs ERROR
    test_import_public_key ERROR
    test_key_generation ERROR

KeypairsTest
    test_keypair_create FAIL
    test_keypair_import FAIL

The trace looks like:

======================================================================
ERROR: test_delete_key_pair (api.ec2.test_cloud.CloudTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/lorin/nova/nova/tests/api/ec2/test_cloud.py", line 1200, in test_delete_key_pair
    self._create_key('test')
  File "/home/lorin/nova/nova/tests/api/ec2/test_cloud.py", line 144, in _create_key
    return cloud._gen_key(self.context, self.context.user_id, name)
  File "/home/lorin/nova/nova/api/ec2/cloud.py", line 73, in _gen_key
    private_key, public_key, fingerprint = crypto.generate_key_pair()
  File "/home/lorin/nova/nova/crypto.py", line 119, in generate_key_pair
    '-f', keyfile)
  File "/home/lorin/nova/nova/utils.py", line 180, in execute
    result = obj.communicate()
  File "/usr/lib64/python2.6/subprocess.py", line 725, in communicate
    stdout, stderr = self._communicate(input, endtime)
  File "/usr/lib64/python2.6/subprocess.py", line 1322, in _communicate
    self.wait(timeout=self._remaining_time(endtime))
TypeError: wait() got an unexpected keyword argument 'timeout'

This is a known issue related to a bug in eventlet.

Mailing list discussion: http://<email address hidden>/msg02545.html

Upstream bug reported:
https://bitbucket.org/which_linden/eventlet/issue/89/add-a-timeout-argument-to-subprocesspopen

[Lorin Hochstein (lorinh)]

Proposed workaround: https://review.openstack.org/1249

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/1249
Committed: http://github.com/openstack/nova/commit/9175822ffeb89268afc6db7900f8b45d738e108c
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 9175822ffeb89268afc6db7900f8b45d738e108c
Author: Lorin Hochstein <email address hidden>
Date: Wed Nov 9 14:00:55 2011 -0500

    Workaround for eventlet bug with unit tests in RHEL6.1.

    This adds a patch to fix the broken eventlet code that's installed in the
    virtualenv.

    Fixes bug 884915

    Change-Id: I6dbf755abbc5a52208de3dd892257ce39686d396