Request id doesn't appear in logs

Bug #879582 reported by Vish Ishaya
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Vish Ishaya
Diablo
Fix Released
Undecided
Unassigned

Bug Description

We have some fancy logging modifications to show information from the context object, but we don't pass the context object into the logs. We should either:

a) add the context object to as many logs as possible

or

b) store the most recent context object in greenthread local storage so that we can access it when we log

Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Vish Ishaya (vishvananda)
status: New → In Progress
importance: Undecided → Low
Changed in nova:
importance: Low → Medium
importance: Medium → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/1022
Committed: http://github.com/openstack/nova/commit/7cca5a8ff7f559da60c03405f69f78a42c763b61
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 7cca5a8ff7f559da60c03405f69f78a42c763b61
Author: Vishvananda Ishaya <email address hidden>
Date: Fri Oct 21 11:18:11 2011 -0700

    Add local storage of context for logging

     * adds nova/local.py:store for storing greenthread local data
     * saves a weak reference to the last context object created
     * uses the last context object if it exists for logging
     * Fixes bug 879582

    Cc: stable-maintainers
    Change-Id: Ic373556ce197f2e8e7d23c807a65b12111db96eb

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (stable/diablo)

Reviewed: https://review.openstack.org/1667
Committed: http://github.com/openstack/nova/commit/17268cab604b0712affc4c0b488769be03605571
Submitter: Jenkins
Branch: stable/diablo

 tag in-stable-diablo
 done

commit 17268cab604b0712affc4c0b488769be03605571
Author: Vishvananda Ishaya <email address hidden>
Date: Fri Oct 21 11:18:11 2011 -0700

    Add local storage of context for logging

     * adds nova/local.py:store for storing greenthread local data
     * saves a weak reference to the last context object created
     * uses the last context object if it exists for logging
     * Fixes bug 879582

    (cherry picked from commit 7cca5a8ff7f559da60c03405f69f78a42c763b61)

    Cc: stable-maintainers
    Change-Id: Ic373556ce197f2e8e7d23c807a65b12111db96eb

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Vish, or anyone else affected,

Accepted nova into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.