instance_get_all_by_filters now does 2 DB queries, but they can be consolidated into 1.
Bug #854239 reported by
Chris Behrens
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Chris Behrens |
Bug Description
2nd DB query needs to go away. You can add this to the first one:
if instance_uuids:
query_prefix = query_prefix.
And then restore the old: instances = query_prefix.all() that should go right before the regexp filtering.
Related branches
lp:~cbehrens/nova/lp854239
- Devin Carlen (community): Approve
- Jason Kölker (community): Approve
- Kevin L. Mitchell (community): Approve
- Josh Kearney (community): Approve
- Brian Waldon: Pending requested
-
Diff: 230 lines (+37/-51)7 files modifiednova/compute/api.py (+3/-2)
nova/db/api.py (+6/-7)
nova/db/sqlalchemy/api.py (+12/-28)
nova/network/manager.py (+3/-6)
nova/tests/fake_network.py (+5/-3)
nova/tests/test_compute.py (+2/-2)
nova/tests/test_db_api.py (+6/-3)
Changed in nova: | |
assignee: | nobody → Chris Behrens (cbehrens) |
status: | New → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → essex-1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | essex-1 → 2012.1 |
To post a comment you must log in.