wrap_exception munges exceptions which aren't Error or NovaException

Bug #851514 reported by Dan Prince on 2011-09-16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Dan Prince

Bug Description

exception.wrap_exception munges exceptions which aren't instances of Error or NovaException. This can lead to really confusing stack traces like:

2011-09-15 12:37:02,599 ERROR nova.rpc [-] Exception during message handling
(nova.rpc): TRACE: Traceback (most recent call last):
(nova.rpc): TRACE: File "/usr/lib/pymodules/python2.6/nova/rpc/impl_kombu.py", line 620, in _process_data
(nova.rpc): TRACE: rval = node_func(context=ctxt, **node_args)
(nova.rpc): TRACE: File "/usr/lib/pymodules/python2.6/nova/exception.py", line 129, in wrapped
(nova.rpc): TRACE: raise Error(str(e))
(nova.rpc): TRACE: Error: list index out of range
(nova.rpc): TRACE:

Good luck finding that one!

We have code in place to capture the exception stack trace before utils.to_primative munges everything for notification. Looks like we only use this code if the original exception inherits from Error or NovaException. We should robustly log all exceptions!

Related branches

Matt Dietz (community): Approve on 2011-09-20
Todd Willey (community): Needs Information on 2011-09-16
Brian Lamar (community): Approve on 2011-09-16
Dan Prince (dan-prince) on 2011-09-16
Changed in nova:
status: New → In Progress
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → High
Dan Prince (dan-prince) on 2011-09-22
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2011-11-09
Changed in nova:
milestone: none → essex-1
Thierry Carrez (ttx) on 2011-11-17
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers