network_info is generated/used haphazardly throughout tests
Bug #822998 reported by
Trey Morris
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Trey Morris | ||
Bug Description
It so happens that many of the virt layer tests pass around and receive network_info. This network_info is arbitrarily hardcoded on the spot and then run through the tests. The problem is these hardcoded "network_info"s are not necessarily accurate, and if the format of network_info changes, the tests will continue to use incorrect values which will cause false positive results in our testing framework.
Related branches
lp:~tr3buchet/nova/lp822998
- Alex Meade (community): Approve
- Rick Harris (community): Approve
- Devin Carlen (community): Approve
-
Diff: 669 lines (+254/-138)4 files modifiednova/tests/fake_network.py (+164/-0)
nova/tests/test_libvirt.py (+56/-93)
nova/tests/test_network.py (+32/-43)
nova/virt/libvirt/firewall.py (+2/-2)
| Changed in nova: | |
| assignee: | nobody → Trey Morris (tr3buchet) |
| Changed in nova: | |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
| Changed in nova: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Soren Hansen (soren) wrote Re: [Bug 822998] [NEW] network_info is generated/used haphazardly throughout tests | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → essex-1 |
| Changed in nova: | |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | essex-1 → 2012.1 |
To post a comment you must log in.
For some of the tests that are coming for libvirt
(lp:~soren/nova/virt-test-improvements) I add a tests/utils.py that
generates a network_info "object" for my tests. I'm hoping we'll --
over time -- rework all tests to use the same method for generating
network_info objects so that we only have one of these to keep that
up-to-date.