ESX(i) : Incorrect machine id parameters in vmx for guest_tool.py
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Arvind Somya |
Bug Description
The guest_tool.py script provided for vmware integration asserts an exact length of 6 on the split machine.id that provides all networking information but the length of machine.id written by vmops is only 4.
assert len(network_
machine_
The machine.id is missing the broadcast and dns and the guest_tool.py fails everytime it tries to set the network address in the guest.
Additionally the guest_tool.py script is incompatible with python 2.6, it keeps failing with the error message:
Traceback (most recent call last):
File "guest_tool.py", line 387, in <module>
_linux_
File "guest_tool.py", line 371, in _linux_
check_
File "guest_tool.py", line 207, in _execute
logging.
NameError: global name '_' is not defined
The script does not support Ubuntu distributions.
Related branches
- Vish Ishaya (community): Approve
- Rick Harris (community): Approve
-
Diff: 255 lines (+113/-18)5 files modifiedAuthors (+1/-0)
nova/virt/vmwareapi/network_utils.py (+24/-4)
nova/virt/vmwareapi/vm_util.py (+25/-7)
nova/virt/vmwareapi/vmops.py (+11/-4)
tools/esx/guest_tool.py (+52/-3)
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → diablo-3 |
Changed in nova: | |
milestone: | diablo-3 → 2011.3 |
status: | Fix Committed → Fix Released |
Attaching a diff that fixes the aforementioned issues:
- Write the required 6 length machine.id to the vmx file.
- Added support for the implicit gettext translations ( _() ).
- Added support for Ubuntu distros.