Use of now/utcnow inconsistent
Bug #792097 reported by
Vish Ishaya
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Vish Ishaya | ||
Bug Description
The codebase is using datetime.now datetime.utcnow and utils.utcnow. We should have one consistent method for getting now. There aren't any specific bugs resulting from this issue, but this an important cleanup for the future.
Related branches
lp:~vishvananda/nova/consistent-utcnow
- Josh Kearney (community): Approve
- Devin Carlen (community): Approve
-
Diff: 905 lines (+77/-95)31 files modifiedbin/nova-manage (+1/-2)
nova/api/ec2/admin.py (+1/-2)
nova/api/ec2/cloud.py (+2/-3)
nova/api/openstack/auth.py (+2/-3)
nova/api/openstack/contrib/__init__.py (+1/-1)
nova/api/openstack/limits.py (+1/-1)
nova/api/openstack/ratelimiting/__init__.py (+1/-1)
nova/compute/api.py (+1/-2)
nova/compute/manager.py (+1/-2)
nova/compute/monitor.py (+1/-1)
nova/context.py (+0/-1)
nova/db/sqlalchemy/api.py (+14/-15)
nova/db/sqlalchemy/migrate_repo/versions/016_make_quotas_key_and_value.py (+5/-5)
nova/db/sqlalchemy/models.py (+4/-5)
nova/network/manager.py (+1/-1)
nova/notifier/api.py (+3/-4)
nova/scheduler/driver.py (+2/-1)
nova/scheduler/simple.py (+5/-6)
nova/scheduler/zone_manager.py (+8/-7)
nova/test.py (+2/-2)
nova/tests/api/openstack/fakes.py (+1/-2)
nova/tests/api/openstack/test_images.py (+0/-1)
nova/tests/api/openstack/test_servers.py (+4/-4)
nova/tests/test_compute.py (+2/-3)
nova/tests/test_console.py (+0/-2)
nova/tests/test_middleware.py (+0/-1)
nova/tests/test_scheduler.py (+8/-8)
nova/utils.py (+1/-1)
nova/virt/xenapi/fake.py (+2/-2)
nova/volume/api.py (+2/-3)
nova/volume/manager.py (+1/-3)
| Changed in nova: | |
| status: | New → In Progress |
| importance: | Undecided → Wishlist |
| assignee: | nobody → Vish Ishaya (vishvananda) |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → diablo-2 |
| Changed in nova: | |
| milestone: | diablo-2 → 2011.3 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
