OpenStack Compute (nova)

OSAPI overLimit exceptions should use HTTP 413 error codes

Bug #785812 reported by Dan Prince
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Troy Toman
OpenStack Compute (nova) 2011.3 "diablo"

Bug Description

The HTTP return codes you get when you actually hit a quota limit are a weird mix. I get a 500 level error code when I hit a RAM limit (the one you are adding this this merge prop). Just for fun I tried another one for the personality limit and I got an HTTP 400 error code. Looking at the SPEC again it looks like we should actually be returning a HTTP 413 'overLimit' error code.

Related branches

lp:~troy-toman/nova/lp785812
Brian Waldon (community): Approve
Dan Prince (community): Approve
Jay Pipes (community): Approve
Diff: 135 lines (+22/-12)
8 files modified
Authors (+1/-0)
nova/api/openstack/common.py (+2/-1)
nova/api/openstack/create_instance_helper.py (+10/-3)
nova/api/openstack/server_metadata.py (+2/-1)
nova/quota.py (+1/-1)
nova/tests/api/openstack/test_image_metadata.py (+2/-2)
nova/tests/api/openstack/test_server_actions.py (+2/-2)
nova/tests/api/openstack/test_server_metadata.py (+2/-2)
Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Titan (rackspace-titan)
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Thierry Carrez (ttx) wrote :

@Titan team: are you working on that, or should we unassign you to let someone else potentially have a try at it ?

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Anybody can take care of it.

Changed in nova:
assignee: Titan (rackspace-titan) → nobody
Revision history for this message
Dan Prince (dan-prince) wrote :

It has been 3 months and nobody has fixed this... Re-assigning to me for now. Hope to have me and/or someone on titan take a look soon.

Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
Revision history for this message
Troy Toman (troy-toman) wrote :

I got a change to take a look at this and think I have created a fix. A branch is linked above. I have not been able to put together a test yet for the InstanceLimitExceeded error that was not being raised as a 413 previously. The tests for the instance and image metadata and personality items have been changed and should provide validation for the fix. I plan to look at that tomorrow.

Dan Prince (dan-prince)
Changed in nova:
assignee: Dan Prince (dan-prince) → Troy Toman (troy-toman)
status: Confirmed → In Progress
OpenStack Infra (hudson-openstack)
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-4
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-4 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.