Parameter mismatch when calling _create_image() from spawn() in libvirt_conn.py

[Yoshiaki Tamura]

The definition of _create_image() in nova/virt/libvirt_conn.py is:

def _create_image(self, inst, libvirt_xml, suffix='', disk_images=None, network_info=None):

However in spawn(), it's passing network_info to suffix:

def spawn(self, instance, network_info=None):
    ...
    self._create_image(instance, xml, network_info)

It should be fixed to:
self._create_image(instance, xml, network_info=network_info)

[Yoshiaki Tamura (tamura-yoshiaki)]

I've updated my branch that first introduces a test which checks spawn() with network_info specified, and followed by the fix.