If the console.log contains control characters, get console output fails with UnknownError

[Vish Ishaya]

This is due to rpc trying to serialize the message to utf-8

2011-04-11 19:51:19,232 ERROR nova [-] Exception during message handling
(nova): TRACE: Traceback (most recent call last):
(nova): TRACE: File "/usr/lib/pymodules/python2.6/nova/rpc.py", line 202, in _receive
(nova): TRACE: msg_reply(msg_id, rval, None)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/nova/rpc.py", line 260, in msg_reply
(nova): TRACE: publisher.send({'result': reply, 'failure': failure})
(nova): TRACE: File "/usr/lib/pymodules/python2.6/carrot/messaging.py", line 753, in send
(nova): TRACE: serializer=serializer)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/carrot/messaging.py", line 682, in create_message
(nova): TRACE: serializer=serializer)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/carrot/serialization.py", line 137, in encode
(nova): TRACE: payload = encoder(data)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/anyjson/__init__.py", line 123, in <lambda>
(nova): TRACE: serialize = lambda value: implementation.serialize(value)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/anyjson/__init__.py", line 83, in serialize
(nova): TRACE: return self._encode(data)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/simplejson/__init__.py", line 230, in dumps
(nova): TRACE: return _default_encoder.encode(obj)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/simplejson/encoder.py", line 200, in encode
(nova): TRACE: chunks = self.iterencode(o, _one_shot=True)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/simplejson/encoder.py", line 260, in iterencode
(nova): TRACE: return _iterencode(o, 0)
(nova): TRACE: UnicodeDecodeError: 'utf8' codec can't decode byte 0xff in position 5618: unexpected code byte
(nova): TRACE:
2011-04-11 19:51:19,235 ERROR nova.rpc [-] Returning exception 'utf8' codec can't decode byte 0xff in position 5618: unexpected code byte to caller

[Thierry Carrez (ttx)]

Cool bug.

[Yuriy Taraday (yorik-sar)]

Got the same error. Patch in attachment.
Unfortunately, after slipping through all modules we can get only ascii-allowed symbols.
So I added some sanitizing into libvirt driver since get_console_output is implemented in this driver only. Probably, this should be done in more abstract way.

[Yuriy Taraday (yorik-sar)]

Created branch and proposed it for merging.