When files are injected into a disk image, they should have a comment e.g. "Injected during boot by the OpenStack cloud"

[justinsb]

When files are injected into a disk image, they should have a comment e.g. "# Injected during boot by the OpenStack cloud"

Otherwise it's difficult to know where they came from!

[justinsb (justin-fathomdb)]

To clarify, I mean files that are generated by nova, like /etc/network/interfaces and .ssh/authorized_keys, not files passed in the API call

[Mark McLoughlin (markmc)]

Ok, for network config, just add the comment here:

  ./nova/virt/interfaces.template

For ssh keys and meta.js: just add the comment to the process_input args in:

  nova/virt/disk.py:_inject_key_into_fs()
  nova/virt/disk.py:_inject_metadata_into_fs()

It doesn't make sense to add a comment for files from files_to_inject, since we can't know their format

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3701

[Brian Waldon (bcwaldon)]

We can't inject into the metadata file since it is a json object (which you can't pollute with comments!)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/3701
Committed: http://github.com/openstack/nova/commit/76e79792b4b94c9edac0ebf3cdf3eb49c7999398
Submitter: Jenkins
Branch: master

commit 76e79792b4b94c9edac0ebf3cdf3eb49c7999398
Author: Brian Waldon <email address hidden>
Date: Thu Feb 2 12:06:38 2012 -0800

    Add comments to injected keys and network config

    Fixes bug 754950

    Change-Id: Ib773479c3b34b9ddd322abd02b297acf5359a847