Wishlist: Nova-network dnsmasq settings are static

[Kevin Bringard]

When nova-network starts dnsmasq, the flags are statically defined in the code. Adding a dnsmasq_config_file option to the FLAGS definition allows this to be easily extended while not affecting the original functionality if the flag is not defined.

The option to tune dnsmasq is useful in many situations, such as defining domain= to set the domain for multiple subnets/projects, or to setup DNS delegation and fine tune upstream resolvers.

[Kevin Bringard (kbringard)]

Adds the flag with the directive dnsmasq_config_file. If the flag is not specified it defaults to blank exactly as it does today.

[Vish Ishaya (vishvananda)]

This is a good point. I've set the status back to confirmed because we e reserve fix committed status for when the fix merges into trunk. If you have time it would be great to propose your branch for review. I would in advance make a few suggestions:
 * Default the flag to None
 * Use an if block and only pass the flag if it is set

Also a question: will the conf file override the other command line arguments that are passed in? If not, it may be better to actually move all of the command line arguments into a template file, and instantiate the template for each version of dnsmasq. A user could specify different configurations using the template file.

[Vish Ishaya (vishvananda)]

Hmm, I just noticed your comment that the config file is normally blank. In that case, your use of the flag seems fine, and you can ignore my first suggesions. You are missing a space after the % in the line where you use the flag, and I'm still curious about the conf file vs command line args.

[Kevin Bringard (kbringard)]

The config file overrides overrides options specified on the command line for options that are only allowed to be specified once (http://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html).

I'll go back and look at the spacing issue, thanks for the feedback.

Oh, and sorry about changing the status. First commit and all, so I'm sorting out the procedure :-D

[Kevin Bringard (kbringard)]

Comitted and pushed rev 892 which fixes the % FLAGS. spacing issue. Interestingly enough, it seems to be working without the space in my environment, so I'll have to go back and check on that :-/

[Vish Ishaya (vishvananda)]

It works fine without the space; it just looks bad and it will fail the pep8 check.
On Mar 25, 2011, at 9:57 AM, Kevin Bringard wrote:

> Comitted and pushed rev 892 which fixes the % FLAGS. spacing issue.
> Interestingly enough, it seems to be working without the space in my
> environment, so I'll have to go back and check on that :-/
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/742578
>
> Title:
> Wishlist: Nova-network dnsmasq settings are static
>
> Status in OpenStack Compute (Nova):
> Confirmed
>
> Bug description:
> When nova-network starts dnsmasq, the flags are statically defined in
> the code. Adding a dnsmasq_config_file option to the FLAGS definition
> allows this to be easily extended while not affecting the original
> functionality if the flag is not defined.
>
> The option to tune dnsmasq is useful in many situations, such as
> defining domain= to set the domain for multiple subnets/projects, or
> to setup DNS delegation and fine tune upstream resolvers.