OpenStack Compute (nova)

Incorrect method naming scheme for Auth Token database interactions

Bug #724633 reported by Matt Dietz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Todd Willey
OpenStack Compute (nova) 2011.2 "cactus"

Bug Description

Specifically, as per comments from Vish on lp718999, auth_get_token and auth_destroy_token are named incorrectly and should be named auth_token_get() and auth_token_destroy() respectively. A fair amount of the OS API auth code and unit tests reference these incorrect names.

Related branches

lp:~xtoddx/nova/lp724633
Devin Carlen (community): Approve
Vish Ishaya (community): Approve
Matt Dietz: Pending requested
Diff: 156 lines (+34/-24)
5 files modified
nova/api/openstack/auth.py (+3/-3)
nova/db/api.py (+10/-10)
nova/db/sqlalchemy/api.py (+7/-4)
nova/tests/api/openstack/fakes.py (+12/-5)
nova/tests/api/openstack/test_auth.py (+2/-2)
Revision history for this message
Matt Dietz (cerberus) wrote :

I think the above is low or wishlist priority. However, I'm not sure whether or not I should be the one to decide that?

Revision history for this message
Jay Pipes (jaypipes) wrote :

is this ONLY the OS API or does the EC2 API also use db.auth_get_token()?

Revision history for this message
Todd Willey (xtoddx) wrote :

EC2 doesn't use it.

Changed in nova:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Todd Willey (xtoddx)
OpenStack Infra (hudson-openstack)
Changed in nova:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → 2011.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.