libvirt: swtpm_ioctl is required for vTPM support

[Takashi Kajinami]

Description
===========
Libvirt uses swtpm_ioctl to shutdown the swtpm process at VM termination, because QEMU does not send shutdown command.
However the binary is not included in the required binaries (swtpm and swtpm_setup, at the time of writing) checked by libvirt driver. So users can use vTPM support without binaries, which leaves swtpm processes kept running.

Steps to reproduce
==================
* Deploy nova-compute with vTPM support
* Move swtpm_ioctl from PATH
* Restart nova-compute

Expected result
===============
nova-compute fails to start because swtpm_ioctl is missing

Actual result
=============
nova-compute starts without error and reports TPM traits.

Environment
===========
This issue was initially found in master, but would be present in stable branches.

Logs & Configs
==============
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/908546

[Takashi Kajinami (kajinamit)]

The relevant commit in libvirt is https://github.com/libvirt/libvirt/commit/69122bc2f1a4f33a019e4e939bb12687a0f527d3 .

Currently libvirt reports availability of emulated vTPM only when swtpm_ioctl exists, but the logic in nova is not aligned with it.

[Takashi Kajinami (kajinamit)]

Ignore my previous comment...

Usage of swtpm_ioctl was addedx when support for external TPM, run by swtpm, was added in https://github.com/libvirt/libvirt/commit/2a606b863ebdc0a74e87c453bb9b76278a72d13b .

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/908546
Committed: https://opendev.org/openstack/nova/commit/9a11bb25238288139c4473d9d91bf365ed88f435
Submitter: "Zuul (22348)"
Branch: master

commit 9a11bb25238288139c4473d9d91bf365ed88f435
Author: Takashi Kajinami <email address hidden>
Date: Fri Feb 9 12:16:45 2024 +0900

    libvirt: Ensure swtpm_ioctl is available for vTPM support

    Libvirt uses swtpm_ioctl to terminate swtpm processes. If the binary
    does not exist, swtpm processes are kept running after the associated
    VM terminates, because QEMU does not send shutdown to swtpm.

    Closes-Bug: #2052761
    Change-Id: I682f71512fc33a49b8dfe93894f144e48f33abe6

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 30.0.0.0rc1 release candidate.