Unit test fails with oslo.utils 6.3.0

Bug #2043116 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Undecided
Takashi Kajinami
OpenStack Compute (nova)
Fix Released
Undecided
Takashi Kajinami

Bug Description

Description
===========

We recently created oslo.utils 6.3.0 release which includes the fix for the bug[1] affecting sqlalchemy-master jobs.

However when we attempt to bump the version in u-c file[2], unit tests of ironic and nova fail with the following errors.

```
nova.tests.unit.objects.test_objects.TestRegistry.test_hook_keeps_newer_properly
--------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/usr/lib/python3.10/unittest/mock.py", line 1379, in patched
    return func(*newargs, **newkeywargs)

      File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/unit/objects/test_objects.py", line 1060, in test_hook_keeps_newer_properly
    reg.registration_hook(MyObj, 0)

      File "/home/zuul/src/opendev.org/openstack/nova/nova/objects/base.py", line 72, in registration_hook
    cur_version = versionutils.convert_version_to_tuple(

      File "/home/zuul/src/opendev.org/openstack/nova/.tox/py310/lib/python3.10/site-packages/oslo_utils/versionutils.py", line 91, in convert_version_to_tuple
    version_str = re.sub(r'(\d+)(a|alpha|b|beta|rc)\d+$', '\\1', version_str)

      File "/usr/lib/python3.10/re.py", line 209, in sub
    return _compile(pattern, flags).sub(repl, string, count)

    TypeError: expected string or bytes-like object
```

[1] https://bugs.launchpad.net/oslo.utils/+bug/2042886
[2] https://review.opendev.org/c/openstack/requirements/+/900517

Changed in nova:
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/900532

Changed in nova:
status: New → In Progress
description: updated
Changed in ironic:
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/900533

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.opendev.org/c/openstack/ironic/+/900533
Committed: https://opendev.org/openstack/ironic/commit/fa8df69194be12b9fe97253d8dd14013381ca92a
Submitter: "Zuul (22348)"
Branch: master

commit fa8df69194be12b9fe97253d8dd14013381ca92a
Author: Takashi Kajinami <email address hidden>
Date: Fri Nov 10 00:05:52 2023 +0900

    Fix unit tests broken by olso.utils

    Some of the object unit tests grub Mock object unintentionally, and
    that results in failure during initializing an versioned object,
    because the Mock object does not present its version correctly.

    This fixes that problem.

    The sqlalchemy-2x job is made non-voting because this job requires
    oslo.utils 6.3.0 which is blocked by this problem.

    Closes-Bug: #2043116
    Related-Bug: #2042886
    Change-Id: I1a622ab9c766d46b7eb4442848e91f25b26f6c61

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/900532
Committed: https://opendev.org/openstack/nova/commit/e04d20a8bc3cfea11c9699219919d0a0158d74fb
Submitter: "Zuul (22348)"
Branch: master

commit e04d20a8bc3cfea11c9699219919d0a0158d74fb
Author: Takashi Kajinami <email address hidden>
Date: Thu Nov 9 23:58:39 2023 +0900

    Fix unit tests broken by olso.utils

    Some of the object unit tests grub Mock object unintentionally, and
    that results in failure during initializing an versioned object,
    because the Mock object does not present its version correctly.

    This fixes that problem

    The sqlalchemy-2x job is made non-voting because this job requires
    oslo.utils 6.3.0 which is blocked by this problem.

    Closes-Bug: #2043116
    Related-Bug: #2042886
    Change-Id: Id1c1b77c020e2d8f0ac61c2aee86c9f37d388d53

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 23.1.0

This issue was fixed in the openstack/ironic 23.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 29.0.0.0rc1

This issue was fixed in the openstack/nova 29.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.