[ironic driver] Shards are not properly queried for

[Jay Faulkner]

While attempting to setup CI to further validate support for shards, I found the following behavior:

- the ironic api logs showed no shards= being provided in the query
- no nodes showed in the resource inventory, failing CI on this change: https://review.opendev.org/c/openstack/ironic/+/894460

On a held devstack node, I was able to reproduce and resolve the problem by using the proper, plural query string "shards" instead of "shard".

Patch incoming.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/894833

[Sylvain Bauza (sylvain-bauza)]

Reverts are provided : https://review.opendev.org/c/openstack/nova/+/894946

[Jay Faulkner (jason-oldos)]

Tracking some followups to this here: https://etherpad.opendev.org/p/nova-sharding-rca

The first order problem was:
- OpenStackSDK was not updated to permit querying by shards, and various overrides for forcing microversion and acceptance unknown fields were not functioning.

While this has been fixed in openstacksdk (and 2023.2, which is landing now), we would have to perform a release, get an RFE just to land a minimally tested feature. As a result, we decided to revert sharding as a feature until CI can be introduced that validates it separates nova-computes properly.

Next cycle, we will land sharding alongside support CI to ensure it's fully working before releasing it to users.

[Sylvain Bauza (sylvain-bauza)]

removing the bobcat-rc-potential tag since we reverted the changes before RC1.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Jay Faulkner <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/nova/+/894833
Reason: will not be needed/separate patch for new sharding in C