nova.test.SubclassSignatureTestCase no longer works
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
melanie witt |
Bug Description
I found this the hard way while working on a patch that added a keyword argument to the signature of nova.virt.
I had missed updating some of the volume drivers and LibvirtBaseVolu
After some digging, I found that SubclassSignatu
it returned true if the object was a bound or an unbound method [2] but as of python 3, it only returns true if the object is a bound method [2].
So in this code [3]:
# the base class. It's redundant for us to test these, but as
# they'll always pass it's not worth the complexity to filter them out.
for (name, method) in inspect.
inspect.
As of python 3, we need to use inspect.
[1] https:/
[2] https:/
[3] https:/
Fix proposed to branch: master /review. opendev. org/c/openstack /nova/+ /883217
Review: https:/