Nova 26 needs to depend on os-traits >= 2.9.0

Bug #1990121 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Committed
High
Thomas Goirand
Trunk
Fix Released
High
Thomas Goirand
Zed
Fix Released
High
Thomas Goirand

Bug Description

Without the latest os-traits, we get unit test failures like below.

======================================================================
FAIL: nova.tests.unit.compute.test_pci_placement_translator.TestTranslator.test_trait_normalization_09
nova.tests.unit.compute.test_pci_placement_translator.TestTranslator.test_trait_normalization_09
----------------------------------------------------------------------
testtools.testresult.real._StringException: pythonlogging:'': {{{
2022-09-17 10:46:54,848 WARNING [oslo_policy.policy] JSON formatted policy_file support is deprecated since Victoria release. You need to use YAML format which will be default in future. You can use ``oslopolicy-convert-json-to-yaml`` tool to convert existing JSON-formatted policy file to YAML-formatted in backward compatible way: https://docs.openstack.org/oslo.policy/latest/cli/oslopolicy-convert-json-to-yaml.html.
2022-09-17 10:46:54,849 WARNING [oslo_policy.policy] JSON formatted policy_file support is deprecated since Victoria release. You need to use YAML format which will be default in future. You can use ``oslopolicy-convert-json-to-yaml`` tool to convert existing JSON-formatted policy file to YAML-formatted in backward compatible way: https://docs.openstack.org/oslo.policy/latest/cli/oslopolicy-convert-json-to-yaml.html.
2022-09-17 10:46:54,851 WARNING [oslo_policy.policy] Policy Rules ['os_compute_api:extensions', 'os_compute_api:os-floating-ip-pools', 'os_compute_api:os-quota-sets:defaults', 'os_compute_api:os-availability-zone:list', 'os_compute_api:limits', 'project_member_api', 'project_reader_api', 'project_member_or_admin', 'project_reader_or_admin', 'os_compute_api:limits:other_project', 'os_compute_api:os-lock-server:unlock:unlock_override', 'os_compute_api:servers:create:zero_disk_flavor', 'compute:servers:resize:cross_cell', 'os_compute_api:os-shelve:unshelve_to_host'] specified in policy files are the same as the defaults provided by the service. You can remove these rules from policy files which will make maintenance easier. You can detect these redundant rules by ``oslopolicy-list-redundant`` tool also.
}}}

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/ddt.py", line 191, in wrapper
    return func(self, *args, **kwargs)
  File "/<<PKGBUILDDIR>>/nova/tests/unit/compute/test_pci_placement_translator.py", line 92, in test_trait_normalization
    ppt._get_traits_for_dev({"traits": trait_names})
  File "/<<PKGBUILDDIR>>/nova/compute/pci_placement_translator.py", line 78, in _get_traits_for_dev
    os_traits.COMPUTE_MANAGED_PCI_DEVICE
AttributeError: module 'os_traits' has no attribute 'COMPUTE_MANAGED_PCI_DEVICE'

tags: added: zed-rc-potential
Changed in nova:
status: New → Confirmed
importance: Undecided → Critical
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Sylvain Bauza (sylvain-bauza) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/858236
Committed: https://opendev.org/openstack/nova/commit/6a06a57290b6f38b6a7c97e47017127472834d1f
Submitter: "Zuul (22348)"
Branch: master

commit 6a06a57290b6f38b6a7c97e47017127472834d1f
Author: Thomas Goirand <email address hidden>
Date: Sat Sep 17 12:56:03 2022 +0200

    requires os-traits >= 2.9.0

    Without the latest version, nova fails many unit tests (it failed
    with os-traits 2.7.0 at least).

    Closes-Bug: #1990121
    Change-Id: I6b320ae1f9058aaa5bac91c7c7ca60136e0cee5c

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/nova/+/858280

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/nova/+/858308

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/zed)

Change abandoned by "Thomas Goirand <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/nova/+/858308
Reason: wrong change-id

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/nova/+/858280
Committed: https://opendev.org/openstack/nova/commit/2db7cbf7d0a6692a885968bec67f48e7262ceec3
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 2db7cbf7d0a6692a885968bec67f48e7262ceec3
Author: Thomas Goirand <email address hidden>
Date: Sat Sep 17 12:56:03 2022 +0200

    requires os-traits >= 2.9.0

    Without the latest version, nova fails many unit tests (it failed
    with os-traits 2.7.0 at least).

    Closes-Bug: #1990121
    Change-Id: I6b320ae1f9058aaa5bac91c7c7ca60136e0cee5c
    (cherry picked from commit 6a06a57290b6f38b6a7c97e47017127472834d1f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 26.0.0.0rc2

This issue was fixed in the openstack/nova 26.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 27.0.0.0rc1

This issue was fixed in the openstack/nova 27.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.