Resize with changing pci alias schedules accoring to the old flavor

[Balazs Gibizer]

Nova does not consider the pci_alias from the new flavor extra_specs during the scheduling of the resize. The new pci_request only applied by the resource_tracker during the move claim[1].

This leads to a behavior where during the scheduling of the resize nova selects the target host according to the old flavor's pci_request but then at the selected host it will allocate PCI devices properly based on the new flavor.

[1] https://github.com/openstack/nova/blob/adeea3d5e7d7337d2817dd5c46334c76c05995ef/nova/compute/resource_tracker.py#L287-L299

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/852295

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/852296

[Artom Lifshitz (notartom)]

Isn't this a duplicate of https://bugs.launchpad.net/nova/+bug/1941005?

[Balazs Gibizer (balazs-gibizer)]

Yes it is, I realized it when the fix fixed your reproducer too. :) I noted both bug in the commit message. I mark this as duplicate now.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/852295
Committed: https://opendev.org/openstack/nova/commit/6d602c6b734c2e360fa319ba22c2fced02ad3d29
Submitter: "Zuul (22348)"
Branch: master

commit 6d602c6b734c2e360fa319ba22c2fced02ad3d29
Author: Balazs Gibizer <email address hidden>
Date: Sat Aug 6 14:48:52 2022 +0200

    Reproducer for bug 1983753

    Related-Bug: #1983753
    Change-Id: Ic6566272b8c5af57cd1c73c73b3cba6cd265bebe

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/852296
Committed: https://opendev.org/openstack/nova/commit/a93092e0d5c1483f9ad48276708ee35c54ce44fe
Submitter: "Zuul (22348)"
Branch: master

commit a93092e0d5c1483f9ad48276708ee35c54ce44fe
Author: Balazs Gibizer <email address hidden>
Date: Sat Aug 6 16:09:54 2022 +0200

    Update RequestSpec.pci_request for resize

    Nova uses the RequestSpec.pci_request in the PciPassthroughFilter to
    decide if the PCI devicesm, requested via the pci_alias in the flavor
    extra_spec, are available on a potential target host. During resize the
    new flavor might contain different pci_alias request than the old flavor
    of the instance. In this case Nova should use the pci_alias from the new
    flavor to scheduler the destination host of the resize. However this
    logic was missing and Nova used the old pci_request value based on the
    old flavor. This patch adds the missing logic.

    Closes-Bug: #1983753
    Closes-Bug: #1941005
    Change-Id: I73c9ae27e9c42ee211a53bed3d849650b65f08be

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/853265

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/nova/+/853266

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/nova/+/853267

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/nova/+/853268

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/nova/+/853269

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/nova/+/853270

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/nova/+/853271

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/853273

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/853274

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/853275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853265
Committed: https://opendev.org/openstack/nova/commit/82cdfa23c7a0e269ab038e241bb7428b7f1391aa
Submitter: "Zuul (22348)"
Branch: master

commit 82cdfa23c7a0e269ab038e241bb7428b7f1391aa
Author: Balazs Gibizer <email address hidden>
Date: Tue Aug 16 13:19:03 2022 +0200

    Add reno for fixing bug 1941005

    Related-Bug: #1941005
    Related-Bug: #1983753
    Change-Id: I16ed1143ead3779c87698aa29bac005678db2993

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 26.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853266
Committed: https://opendev.org/openstack/nova/commit/bdc32226e2d9ce4a073306f8f6267fbe305e64e4
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit bdc32226e2d9ce4a073306f8f6267fbe305e64e4
Author: Balazs Gibizer <email address hidden>
Date: Sat Aug 6 14:48:52 2022 +0200

    Reproducer for bug 1983753

    Related-Bug: #1983753
    Change-Id: Ic6566272b8c5af57cd1c73c73b3cba6cd265bebe
    (cherry picked from commit 6d602c6b734c2e360fa319ba22c2fced02ad3d29)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853267
Committed: https://opendev.org/openstack/nova/commit/b6c7ee07ad2a6503b8aad0921cca70e61e60259d
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit b6c7ee07ad2a6503b8aad0921cca70e61e60259d
Author: Balazs Gibizer <email address hidden>
Date: Sat Aug 6 16:09:54 2022 +0200

    Update RequestSpec.pci_request for resize

    Nova uses the RequestSpec.pci_request in the PciPassthroughFilter to
    decide if the PCI devicesm, requested via the pci_alias in the flavor
    extra_spec, are available on a potential target host. During resize the
    new flavor might contain different pci_alias request than the old flavor
    of the instance. In this case Nova should use the pci_alias from the new
    flavor to scheduler the destination host of the resize. However this
    logic was missing and Nova used the old pci_request value based on the
    old flavor. This patch adds the missing logic.

    Closes-Bug: #1983753
    Closes-Bug: #1941005
    Change-Id: I73c9ae27e9c42ee211a53bed3d849650b65f08be
    (cherry picked from commit a93092e0d5c1483f9ad48276708ee35c54ce44fe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853268
Committed: https://opendev.org/openstack/nova/commit/19bac6e9c362ee692f4be92041bb3f6c3b9b6c23
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 19bac6e9c362ee692f4be92041bb3f6c3b9b6c23
Author: Balazs Gibizer <email address hidden>
Date: Tue Aug 16 13:19:03 2022 +0200

    Add reno for fixing bug 1941005

    Related-Bug: #1941005
    Related-Bug: #1983753
    Change-Id: I16ed1143ead3779c87698aa29bac005678db2993
    (cherry picked from commit 82cdfa23c7a0e269ab038e241bb7428b7f1391aa)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853269
Committed: https://opendev.org/openstack/nova/commit/87a8a7df9800f3c81dba2e2c0520168115ad1b28
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 87a8a7df9800f3c81dba2e2c0520168115ad1b28
Author: Balazs Gibizer <email address hidden>
Date: Sat Aug 6 14:48:52 2022 +0200

    Reproducer for bug 1983753

    Related-Bug: #1983753
    Change-Id: Ic6566272b8c5af57cd1c73c73b3cba6cd265bebe
    (cherry picked from commit 6d602c6b734c2e360fa319ba22c2fced02ad3d29)
    (cherry picked from commit bdc32226e2d9ce4a073306f8f6267fbe305e64e4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853270
Committed: https://opendev.org/openstack/nova/commit/696d27a0e2ccf0916fc6bd3eabf73f2b007e7830
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 696d27a0e2ccf0916fc6bd3eabf73f2b007e7830
Author: Balazs Gibizer <email address hidden>
Date: Sat Aug 6 16:09:54 2022 +0200

    Update RequestSpec.pci_request for resize

    Nova uses the RequestSpec.pci_request in the PciPassthroughFilter to
    decide if the PCI devicesm, requested via the pci_alias in the flavor
    extra_spec, are available on a potential target host. During resize the
    new flavor might contain different pci_alias request than the old flavor
    of the instance. In this case Nova should use the pci_alias from the new
    flavor to scheduler the destination host of the resize. However this
    logic was missing and Nova used the old pci_request value based on the
    old flavor. This patch adds the missing logic.

    Closes-Bug: #1983753
    Closes-Bug: #1941005
    Change-Id: I73c9ae27e9c42ee211a53bed3d849650b65f08be
    (cherry picked from commit a93092e0d5c1483f9ad48276708ee35c54ce44fe)
    (cherry picked from commit b6c7ee07ad2a6503b8aad0921cca70e61e60259d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/853271
Committed: https://opendev.org/openstack/nova/commit/cbf785709968fffc0a760e28f1cdb5c38b254232
Submitter: "Zuul (22348)"
Branch: stable/xena

commit cbf785709968fffc0a760e28f1cdb5c38b254232
Author: Balazs Gibizer <email address hidden>
Date: Tue Aug 16 13:19:03 2022 +0200

    Add reno for fixing bug 1941005

    Related-Bug: #1941005
    Related-Bug: #1983753
    Change-Id: I16ed1143ead3779c87698aa29bac005678db2993
    (cherry picked from commit 82cdfa23c7a0e269ab038e241bb7428b7f1391aa)
    (cherry picked from commit 19bac6e9c362ee692f4be92041bb3f6c3b9b6c23)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/883904

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/883905

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/883906

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/883908

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/883909

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/883930

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/883932

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/883933

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/883934

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/883934
Reason: stable/train branch of nova projects' have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/883932
Reason: stable/train branch of nova projects' have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/883933
Reason: stable/train branch of nova projects' have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 25.2.1 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/883909
Reason: stable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/883930
Reason: stable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/883908
Reason: stable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova xena-eom release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/883905
Reason: stable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/883904
Reason: stable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/883906
Reason: stable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/853274
Reason: stable/wallaby branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/853275
Reason: stable/wallaby branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.