Running tox on ubuntu desktop doesn't work
Bug #1966477 reported by
Thiago Paiva Brito
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
Description
===========
In the current version of nova, I can't run the tox unit tests (tested with py38 and py39) on my development workstation with Ubuntu Desktop 20.04.
Steps to reproduce
==================
Just run tox -e py38 or tox -e py39 in Ubuntu Desktop 20.04
Expected result
===============
Unit tests run without any issue
Actual result
=============
5 tests failing due to a missing configuration oslo_concurrenc
Environment
===========
Nova @86ded7f65d560b
Ubuntu Desktop 20.04
No hypervisor (just unit test run)
Logs & Configs
==============
https:/
To post a comment you must log in.
I got to the bottom if it. Apparently, this is due to Ubuntu Desktop missing the iscsiadm tool that is used by os-brick to get the value of ISCSI_SUPPORTS_ MANUAL_ SCAN at https:/ /github. com/openstack/ os-brick/ blob/master/ os_brick/ initiator/ utils.py# L40. Then the flow goes to the "else" and tries to make a lock, which doesn't happen in the normal flow of the test on zuul.
We have a couple of options here:
#1 add open-iscsi to bindep
#2 add "REQUIRES_LOCKING = True" to the classes that are failing
Besides that, do we need to fix the tests so they can test both flows?