unnecessary if condition in nova/cmd/manage.py

[Rahul Singh]

In 'nova/cmd/manage.py' file, the function '_check_orphaned_allocations_for_provider()' inside 'PlacementCommands' class has below if condition:

-------------------
class PlacementCommands(object):
...
...
    def _check_orphaned_allocations_for_provider(self, ctxt, placement,
                                                 output, provider,
                                                 delete):
        ...
        ...
        # We reset the consumer type for each allocation
        consumer_type = None
        # This is an allocation for Nova resources
        # We need to guess whether the instance was deleted
        # or if the instance is currently migrating
        if not (consumer_uuid in inst_uuids or
                consumer_uuid in mig_uuids):
            # By default we suspect the orphaned allocation was for a
            # migration...
            consumer_type = 'migration'
            if not(consumer_uuid in inst_uuids):
                # ... but if we can't find it either for an instance,
                # that means it was for this.
                consumer_type = 'instance'
        ...
--------------------

Refer: https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L2546-L2554

The first 'if' condition will be 'true' only when :
1. 'consumer_uuid' is not present in 'inst_uuids' and
2. 'consumer_uuid' is not present in 'mig_uuids'

Once this is true, the 'if' condition inside will always be 'true'. So, the 'consumer_type' will always be set to 'instance'. It will never be set to 'migration'.

[Balazs Gibizer (balazs-gibizer)]

Analysis looks correct. Feel free to propose a small patch to remove the unnecessary if.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/844418