LibvirtNVMEVolumeDriverTestCase and LibvirtScaleIOVolumeDriverTestCase unit tests fail on ppc64

[Lee Yarwood]

These tests don't appear to be mocking out their interactions with os-brick correctly leading to it attempting to build unsupported connectors on ppc64el.

https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/periodic/openstack-tox-py39/2021-01-19-0058-38c70ae/job-output.txt

2021-01-19 00:57:49.258887 | devstack-focal-test | nova.tests.unit.virt.libvirt.volume.test_nvme.LibvirtNVMEVolumeDriverTestCase.test_libvirt_nvme_driver_disconnect
2021-01-19 00:57:49.258898 | devstack-focal-test | -----------------------------------------------------------------------------------------------------------------
2021-01-19 00:57:49.258909 | devstack-focal-test |
2021-01-19 00:57:49.258919 | devstack-focal-test | Captured traceback:
2021-01-19 00:57:49.258930 | devstack-focal-test | ~~~~~~~~~~~~~~~~~~~
2021-01-19 00:57:49.258942 | devstack-focal-test | Traceback (most recent call last):
2021-01-19 00:57:49.258952 | devstack-focal-test |
2021-01-19 00:57:49.258963 | devstack-focal-test | File "/home/zuul/src/review.openstack.org/openstack/nova/nova/tests/unit/virt/libvirt/volume/test_nvme.py", line 51, in test_libvirt_nvme_driver_disconnect
2021-01-19 00:57:49.258974 | devstack-focal-test | nvme_con = nvme.LibvirtNVMEVolumeDriver(self.connr)
2021-01-19 00:57:49.258985 | devstack-focal-test |
2021-01-19 00:57:49.258995 | devstack-focal-test | File "/home/zuul/src/review.openstack.org/openstack/nova/nova/virt/libvirt/volume/nvme.py", line 34, in __init__
2021-01-19 00:57:49.259006 | devstack-focal-test | self.connector = connector.InitiatorConnector.factory(
2021-01-19 00:57:49.259017 | devstack-focal-test |
2021-01-19 00:57:49.259027 | devstack-focal-test | File "/home/zuul/src/review.openstack.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/os_brick/initiator/connector.py", line 303, in factory
2021-01-19 00:57:49.259039 | devstack-focal-test | raise exception.InvalidConnectorProtocol(msg)
2021-01-19 00:57:49.259050 | devstack-focal-test |
2021-01-19 00:57:49.259060 | devstack-focal-test | os_brick.exception.InvalidConnectorProtocol: Invalid InitiatorConnector protocol specified NVME

[Lee Yarwood (lyarwood)]

https://review.opendev.org/c/openstack/nova/+/771806 merged

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 23.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/884570

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/884570
Reason: stable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/victoria
Review: https://review.opendev.org/c/openstack/nova/+/926256

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/926256
Committed: https://opendev.org/openstack/nova/commit/107e332c55d96031772268cf8fcbf25aeceb7c3d
Submitter: "Zuul (22348)"
Branch: unmaintained/victoria

commit 107e332c55d96031772268cf8fcbf25aeceb7c3d
Author: Lee Yarwood <email address hidden>
Date: Thu Jan 21 10:11:03 2021 +0000

    libvirt: Stop NVMe and ScaleIO unit tests from calling os-brick

    Both sets of tests would allow calls to the InitiatorConnector.factory
    within os-brick that returns an arch specific connector. When running
    tests on ppc64le hosts this would result in failures are the SCALEIO and
    NVME protocols are not supported on these architectures.

    Closes-Bug: #1912608
    Change-Id: Id917d715c0c0955fbc6761d4b5af386514a343d2
    (cherry picked from commit 0f558749d1489c6399bb009dfd2a1aeda8d85f9c)