excessive logging of rbd and rados import errors

Bug #1903316 reported by Balazs Gibizer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Lee Yarwood

Bug Description

The rbd and rados packages are optional dependencies of the libvirt dirver. The patch https://review.opendev.org/#/c/746873 added logging the import error unconditionally.

relevant IRC discussion: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-11-06.log.html#t2020-11-06T15:07:43

Tags: testing
description: updated
Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Lee Yarwood (lyarwood)
status: Confirmed → In Progress
Changed in nova:
assignee: Lee Yarwood (lyarwood) → Sylvain Bauza (sylvain-bauza)
tags: added: testing
Changed in nova:
assignee: Sylvain Bauza (sylvain-bauza) → Stephen Finucane (stephenfinucane)
Changed in nova:
assignee: Stephen Finucane (stephenfinucane) → Lee Yarwood (lyarwood)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/761762
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4916ab7a4cb67edc0b54a8ee67c58b1302769792
Submitter: Zuul
Branch: master

commit 4916ab7a4cb67edc0b54a8ee67c58b1302769792
Author: Lee Yarwood <email address hidden>
Date: Fri Nov 6 15:41:17 2020 +0000

    rbd: Only log import failures when the RbdDriver is used

    Rework Ie8bb5e5622bd37dfe8073cca12f77174e8e7d98c so we only log failures
    to import the rbd or rados modules when the RbdDriver is used.

    This should reduce noise in the logs at runtime as well as during unit
    and functional tests runs where these modules are not present.

    Change-Id: I150e70629f6ae579ccfe0bf585c8a27df14fb51d
    Closes-Bug: #1903316

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 23.0.0.0rc1

This issue was fixed in the openstack/nova 23.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/victoria)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/758240
Reason: stable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.