Legacy 'InstanceNUMACell' with 'mixed' policy results in 'TypeError'

[Stephen Finucane]

We added support for the 'mixed' CPU policy in Victoria. This required changes to the 'cpu_policy' field of the 'InstanceNUMACell' object. As part of that change, we had to check that the consumer of the o.vo supported the 'mixed' policy and, if not, raise an 'ObjectActionError'.

Unfortunately we're attempting to use a tuple as a string in the string formatting for that exception's error message. As a result, if you attempt to actually raise it, you see the following:

  TypeError: not all arguments converted during string formatting

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/756069

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/756069
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=12cc805d3687fcc27023326c7602deae9c7ac2c4
Submitter: Zuul
Branch: master

commit 12cc805d3687fcc27023326c7602deae9c7ac2c4
Author: Stephen Finucane <email address hidden>
Date: Mon Oct 5 13:48:19 2020 +0100

    objects: Fix issue in exception type

    We were attempting to pass a 'target_version' variable into an exception
    message. 'target_version' is a tuple which means it's expanded out
    resulting in the following error:

      TypeError: not all arguments converted during string formatting

    Fix this.

    Change-Id: I6063b2108ae38776d034fd7a4c3aa88dc66a084f
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1898554

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 23.0.0.0rc1 release candidate.