placement allocation update accepts only integers from 1

Bug #1894825 reported by Lajos Katona
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Lajos Katona

Bug Description

update_qos_minbw_allocation (see: https://opendev.org/openstack/neutron-lib/src/commit/245e005d1bbb9af5e57ff600fb97b2a13c85c83b/neutron_lib/placement/client.py ) assumes that placement allocation records can be updated by 0 (like:
{
  "allocations": {
    "4e061c03-611e-4caa-bf26-999dcff4284e": {
      "resources": {
        "NET_BW_EGR_KILOBIT_PER_SEC": 0
      }
    }
}

),
but that is not possible now, the way to do this is to delete the resource class,
see the storyboard story for this:
https://storyboard.openstack.org/#!/story/2008111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.opendev.org/750349

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.opendev.org/750349
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=a61f9553d2074d160ac384313971421b7f063765
Submitter: Zuul
Branch: master

commit a61f9553d2074d160ac384313971421b7f063765
Author: elajkat <email address hidden>
Date: Tue Sep 8 13:08:45 2020 +0200

    remove rc from allocation dict if value is 0

    update_qos_minbw_allocation now deletes the resource class keys if the
    value for the give resource class is zero, as placement can't handle 0
    value updates, see the referenced story.

    Change-Id: Iaf23eb313507139c2de76146b82d148bcce9b3d6
    Closes-Bug: #1894825
    Related-Bug: #1882804
    Story: 2008111

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/753230

Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (stable/victoria)

Reviewed: https://review.opendev.org/753230
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=73d868b0770cc4ba8500e8058cadf66de98d7666
Submitter: Zuul
Branch: stable/victoria

commit 73d868b0770cc4ba8500e8058cadf66de98d7666
Author: elajkat <email address hidden>
Date: Tue Sep 8 13:08:45 2020 +0200

    remove rc from allocation dict if value is 0

    update_qos_minbw_allocation now deletes the resource class keys if the
    value for the give resource class is zero, as placement can't handle 0
    value updates, see the referenced story.

    Change-Id: Iaf23eb313507139c2de76146b82d148bcce9b3d6
    Closes-Bug: #1894825
    Related-Bug: #1882804
    Story: 2008111
    (cherry picked from commit a61f9553d2074d160ac384313971421b7f063765)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lib 2.7.0

This issue was fixed in the openstack/neutron-lib 2.7.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.