Reject resize operation for accelerator

Bug #1893751 reported by Brin Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Brin Zhang
Ussuri
Fix Released
Low
Brin Zhang

Bug Description

When resize with a new flavor with accelerator, we should raise
forbidden exception to reject the resize operation. As the comments in https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L3931-L3932

Tags: cyborg
Brin Zhang (zhangbailin)
Changed in nova:
importance: Undecided → Low
tags: added: cyborg
Changed in nova:
assignee: nobody → Brin Zhang (zhangbailin)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/748560
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=97267fc05c60b60761ebe8ec2773e8920148ae06
Submitter: Zuul
Branch: master

commit 97267fc05c60b60761ebe8ec2773e8920148ae06
Author: zhangbailin <email address hidden>
Date: Fri Aug 28 09:48:49 2020 +0800

    Reject resize operation for accelerator

    When resize with a new flavor with accelerator, we should raise
    forbidden exception to reject the resize operation.
    Add related unit test.
    Follow up the comment:
    https://review.opendev.org/#/c/715326/22/nova/compute/api.py@3907

    Co-Authored-By: Wenping Song <email address hidden>

    Closes-Bug: #1893751

    Change-Id: Ie20a620588e3b0d18055c34ec7671e91e6bf6ee0

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/749698

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/749701

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/ussuri)

Change abandoned by Brin Zhang (<email address hidden>) on branch: stable/ussuri
Review: https://review.opendev.org/749698
Reason: chaged to Ie20a620588e3b0d18055c34ec7671e91e6bf6ee0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ussuri)

Reviewed: https://review.opendev.org/749701
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3f466079f92084f62f0d0f58b0f0c1bb4fb0ac5b
Submitter: Zuul
Branch: stable/ussuri

commit 3f466079f92084f62f0d0f58b0f0c1bb4fb0ac5b
Author: zhangbailin <email address hidden>
Date: Fri Aug 28 09:48:49 2020 +0800

    Reject resize operation for accelerator

    When resize with a new flavor with accelerator, we should raise
    forbidden exception to reject the resize operation.
    Add related unit test.
    Follow up the comment:
    https://review.opendev.org/#/c/715326/22/nova/compute/api.py@3907

    Conflicts:
      nova/compute/api.py
      nova/tests/unit/compute/test_compute_api.py

    NOTE(brinzhang): Conflicts are due to change
    eef4b5435e7cdfe53ee9d9265d96c7dd278d9e93 ("api: Reject
    non-spawn operations for vTPM") which modified the same code.

    Add 'extra_specs={}' as a request parameter in test_resize_quota_check()
    in nova/tests/unit/compute/test_compute_api.py. Actually this change is
    required due to not having patch
    I147bf4d95e6d86ff1f967a8ce37260730f21d236 in stable ussuri.

    Co-Authored-By: Wenping Song <email address hidden>

    Closes-Bug: #1893751

    Change-Id: Ie20a620588e3b0d18055c34ec7671e91e6bf6ee0
    (cherry picked from commit 97267fc05c60b60761ebe8ec2773e8920148ae06)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.