consecutive_build_service_disable_threshold option is an inappropriate name in current nova

Bug #1892471 reported by Rikimaru Honjo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Confirmed
Wishlist
Unassigned

Bug Description

[Issue]

[compute]consecutive_build_service_disable_threshold option was added by the following patch.

https://review.opendev.org/#/c/463597/

The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.

But, the following patch deleted the feature to automatically disable the service record.

https://review.opendev.org/#/c/572195/

This option's behavior after merging the above patch is this:

* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.

consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.

[Improvement idea]

Update the option name.

e.g.
[compute]enable_reporting_of_build_failures

description: updated
description: updated
description: updated
Changed in nova:
importance: Undecided → Wishlist
Changed in nova:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.