Change default num_retries for glance to 3

[Keigo Noha]

Currently, nova has a parameter to set the retry count for glance, num_retries.
The default value of the option is 0. It means that the request is sent only once.
On the other hand, other component's clients, cinder, neutron change its default value to 3.

https://review.opendev.org/#/c/712226/
https://review.opendev.org/#/c/736026/

For glance, we should align the default value to 3.

[melanie witt (melwitt)]

Here's where we default the cinder retries to 3:

https://github.com/openstack/nova/blob/b7161fe9b92f0045e97c300a80e58d32b6f49be1/nova/conf/cinder.py#L72-L73

and neutron retries are also defaulted to 3:

https://github.com/openstack/nova/blob/b7161fe9b92f0045e97c300a80e58d32b6f49be1/nova/conf/neutron.py#L97-L98

[sean mooney (sean-k-mooney)]

this is not a nova bug it is really a misconfigred haproxy.
the idle timeout is not congirured correctly.

so im really tempted to say we should mark this as invlaid
but i also think seting the value to 3 is fine.

the patch is just chanign the default for the config option so i agree with melanie that this shoudl be low or maybe even wishlist as its trivail to workaroud the issue by setting the config option however teh correct fix is to adjust the haproxy configurtion not alter nova.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/740389
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=662af9fab6eacb46bcaee38d076d33c2c0f82b9b
Submitter: Zuul
Branch: master

commit 662af9fab6eacb46bcaee38d076d33c2c0f82b9b
Author: Keigo Noha <email address hidden>
Date: Fri Jul 10 10:32:02 2020 +0900

    Change default num_retries for glance to 3

    Previously, the default value of num_retries for glance is 0.
    It means that the request to glance is sent only one time.
    On the other hand, neutron and cinder clients set the default
    value to 3.
    To align the default value for retry to other components, we
    should change the default value to 3.

    Closes-Bug: #1888168
    Change-Id: Ibbd4bd26408328b9e1a1128b3794721405631193

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/748936

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748936
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1f9dd694b937cc55a81a64fdce442829f009afb3
Submitter: Zuul
Branch: stable/ussuri

commit 1f9dd694b937cc55a81a64fdce442829f009afb3
Author: Keigo Noha <email address hidden>
Date: Fri Jul 10 10:32:02 2020 +0900

    Change default num_retries for glance to 3

    Previously, the default value of num_retries for glance is 0.
    It means that the request to glance is sent only one time.
    On the other hand, neutron and cinder clients set the default
    value to 3.
    To align the default value for retry to other components, we
    should change the default value to 3.

    Closes-Bug: #1888168
    Change-Id: Ibbd4bd26408328b9e1a1128b3794721405631193
    (cherry picked from commit 662af9fab6eacb46bcaee38d076d33c2c0f82b9b)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/762610

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 20.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 21.1.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova stein-eol release.