interface metadata is not regenerated after interface detach

[Balazs Gibizer]

If a tagged interface is detached from an instance the device metadata is not regenerated and therefore the detached interface still visible to the guest via the metadata service.

When the blueprint virt-device-tagged-attach-detach was implemented the metadata handing was missed in the detach code path https://review.opendev.org/#/c/415520

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/741436

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/741436
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=16429c6b901ae918f75f7b81f99b7e914e86d253
Submitter: Zuul
Branch: master

commit 16429c6b901ae918f75f7b81f99b7e914e86d253
Author: Balazs Gibizer <email address hidden>
Date: Wed Jul 22 16:23:07 2020 +0200

    Delete non tag related device metadata during detach

    When the blueprint virt-device-tagged-attach-detach [1] was
    implemented the metadata cleanup during interface detach made an
    assumption that metadata only exists if the detached vif has tags.
    However metadata exists for vif with vlan information as well. In such
    case the metadata is leaked during interface detach. This patch removes
    this assumption from the detach code path.

    [1] https://review.opendev.org/#/c/415520

    Closes-Bug: #1887799
    Change-Id: Iefdf9c8b024db04867bd5f8794863f0cd65de807