e1000e interface reported as unsupported

[Stephen Finucane]

Per this downstream bug [1], attempting to boot a Windows Server 2012 or 2016 image will fail because libosinfo is attempting to configure an e1000e VIF which nova does not explicitly support. There doesn't appear to be any reason not to support this, since libvirt, and specifically QEMU/KVM, support it.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1839808

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/734777

[Stephen Finucane (stephenfinucane)]

Additional content from comments by Sean on the review. It seems e1000e is the QEMU upstream default for the q35 machine type so not only is it supported, it's actually their new default. We should keep preferring virtio in libvirt because it's a better choice for the cloud. However, QEMU doesn't default to virtio because Windows does not ship with virtio drivers.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/734777
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=644cb5cb8bf44184d9b3f046cc67746b13550dd6
Submitter: Zuul
Branch: master

commit 644cb5cb8bf44184d9b3f046cc67746b13550dd6
Author: Stephen Finucane <email address hidden>
Date: Wed Jun 10 10:56:38 2020 +0100

    libvirt: Mark e1000e VIF as supported

    This is supported by the QEMU/KVM backends in libvirt. There's no reason
    not to support it in nova. This appears to have been an oversight.

    Change-Id: I12a5d28d75bc32a76a4f3765cb4db4cbc46c0c75
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1882919

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/736957

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/736962

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/736957
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=840de3b8924612fa3fc47a4c9032a4723d536613
Submitter: Zuul
Branch: stable/ussuri

commit 840de3b8924612fa3fc47a4c9032a4723d536613
Author: Stephen Finucane <email address hidden>
Date: Wed Jun 10 10:56:38 2020 +0100

    libvirt: Mark e1000e VIF as supported

    This is supported by the QEMU/KVM backends in libvirt. There's no reason
    not to support it in nova. This appears to have been an oversight.

    Change-Id: I12a5d28d75bc32a76a4f3765cb4db4cbc46c0c75
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1882919
    (cherry picked from commit 644cb5cb8bf44184d9b3f046cc67746b13550dd6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/736962
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ddbc262494cf0df3f3abd5b5139eb787bb085f8c
Submitter: Zuul
Branch: stable/train

commit ddbc262494cf0df3f3abd5b5139eb787bb085f8c
Author: Stephen Finucane <email address hidden>
Date: Wed Jun 10 10:56:38 2020 +0100

    libvirt: Mark e1000e VIF as supported

    This is supported by the QEMU/KVM backends in libvirt. There's no reason
    not to support it in nova. This appears to have been an oversight.

    Conflicts:
            nova/virt/libvirt/vif.py

    NOTE(stephenfin): Conflicts are due to absence of change
    I0bdf9ccf7bf3fb1f3136c1e4267b9c99732908d5 ("libvirt: Use domain
    capabilities to get supported device models") which moved the list of
    supported VIFs from a function attribute to a module attribute.

    Change-Id: I12a5d28d75bc32a76a4f3765cb4db4cbc46c0c75
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1882919
    (cherry picked from commit 644cb5cb8bf44184d9b3f046cc67746b13550dd6)
    (cherry picked from commit 840de3b8924612fa3fc47a4c9032a4723d536613)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/742390

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/742390
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5482dde3298ce9679dbb8378fe8e216fc24dd024
Submitter: Zuul
Branch: stable/stein

commit 5482dde3298ce9679dbb8378fe8e216fc24dd024
Author: Stephen Finucane <email address hidden>
Date: Wed Jun 10 10:56:38 2020 +0100

    libvirt: Mark e1000e VIF as supported

    This is supported by the QEMU/KVM backends in libvirt. There's no reason
    not to support it in nova. This appears to have been an oversight.

    Change-Id: I12a5d28d75bc32a76a4f3765cb4db4cbc46c0c75
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1882919
    (cherry picked from commit 644cb5cb8bf44184d9b3f046cc67746b13550dd6)
    (cherry picked from commit 840de3b8924612fa3fc47a4c9032a4723d536613)
    (cherry picked from commit ddbc262494cf0df3f3abd5b5139eb787bb085f8c)