Nova host aggregate cannot sync to placement

[Shi Yan]

Description
===========
We are using the nova stein version.
When adding/removing host from aggregate, nova should sync the host aggregate to placement resource provider aggregate as well. But from our test, it is not working.

Steps to reproduce
==================
1. Check a specific compute node resource provider aggregate
2. Create a new host aggregate and add the compute node into the aggregate
3. Check the compute node resource provider aggregate again to see if the additional aggreate is added

(We got the similar error when removing host from an existing aggregate)

Expected result
===============
An additional resource provider aggregate for the compute node

Actual result
=============
No change.

Logs & Configs
==============

from nova-api:

May 07 09:54:06 nova-api nova-api[26742]: 2020-05-07 09:54:06.364 26742 WARNING nova.compute.api [req-b4542212-7a5c-4d81-b602-4702634015b8 c0645ff94b864d3d84c438d9855f9cea 9427903ca1544f0795ba4117d55ed9b2 - default default] Failed to associate cc2 with a placement aggregate: No such resource provider cc2.. This may be corrected after running nova-manage placement sync_aggregates.: nova.exception.ResourceProviderNotFound: No such resource provider cc2.

Note:
cc2 is the hostname for the compute node, but we use fqdn for the hypervisor. So the name of the resource provider is fqdn(with domain). I think that is the reason why the resource provider cannot be found.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/726201

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726201
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=eb433bf17e84ccba899e025fe3004e7d63c3f19e
Submitter: Zuul
Branch: master

commit eb433bf17e84ccba899e025fe3004e7d63c3f19e
Author: Rocky <email address hidden>
Date: Fri May 8 02:38:51 2020 +1000

    Fix aggregate placement sync issue

    Use node name to sync the nova aggregate to placement resource provider
    aggregate.

    Change-Id: I08f2f07c0c695d1dd5b4fa72d0155e02b1872b0a
    closes-bug: #1877229

[Corey Bryant (corey.bryant)]

This is not yet fixed in upstream or Ubuntu for releases prior to Victoria.