inconsistent connection info data after live migration

[norman shen]

Description
===========

after live migration, block device mapping's connection stays at "attaching",
which is confusing piece of information. The root cause seems caused by
different code path between live migration and attach volume.

Steps to reproduce
==================

attach a volume and then live migrate to different host.

Expected result
================

consistent information. Either there is no info nor connection info should
be reserved.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/717597

[Lee Yarwood (lyarwood)]

Can you use the bug template below and edit your initial comment with some evidence of this and additional information requested in the template?

Description
===========
Some prose which explains more in detail what this bug report is
about. If the headline of this report is descriptive enough, skip
this section.

Steps to reproduce
==================
A chronological list of steps which will bring off the
issue you noticed:
* I did X
* then I did Y
* then I did Z
A list of openstack client commands (with correct argument value)
would be the most descriptive example. To get more information use:

    $ nova --debug <command> <arg1> <arg2=value>
    or
    $ openstack --debug <command> <arg1> <arg2=value>

Expected result
===============
After the execution of the steps above, what should have
happened if the issue wasn't present?

Actual result
=============
What happened instead of the expected result?
How did the issue look like?

Environment
===========
1. Exact version of OpenStack you are running. See the following
  list for all releases: http://docs.openstack.org/releases/

   If this is from a distro please provide
       $ dpkg -l | grep nova
       or
       $ rpm -ql | grep nova
   If this is from git, please provide
       $ git log -1

2. Which hypervisor did you use?
   (For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...)
   What's the version of that?

2. Which storage type did you use?
   (For example: Ceph, LVM, GPFS, ...)
   What's the version of that?

3. Which networking type did you use?
   (For example: nova-network, Neutron with OpenVSwitch, ...)

Logs & Configs
==============
The tool *sosreport* has support for some OpenStack projects.
It's worth having a look at it. For example, if you want to collect
the logs of a compute node you would execute:

   $ sudo sosreport -o openstack_nova --batch

on that compute node. Attach the logs to this bug report. Please
consider that these logs need to be collected in "DEBUG" mode.

For tips on reporting VMware virt driver bugs, please see this doc: https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-vmware.html#troubleshooting