[Neutron API] Neutron Floating IP not always have 'port_details'

[Rodolfo Alonso]

1) Neutron Floating IP 'port_details' key is part of an extension. That means not always will be present in the Floating IP dictionary. Since [1], in [2] is assumed that this key is always present. That should be checked first.

2) The same patch [1] also introduced an error when retrieving the network ID [3]. The network ID is stored in a key named "floating_network_id" [4].

n-api log example: http://paste.openstack.org/show/789108/

CI job failing (breaking Neutron CI!!!): https://0ebef4bf8afa09d1c4c9-5e4b426cf1ca8d9cb4613ee1042e28ab.ssl.cf5.rackcdn.com/704530/4/check/neutron-ovn-tempest-ovs-release/c0a29b4/testr_results.html

[1]https://review.opendev.org/#/c/697153/
[2]https://review.opendev.org/#/c/697153/16/nova/api/openstack/compute/floating_ips.py@40
[3]https://review.opendev.org/#/c/697153/16/nova/api/openstack/compute/floating_ips.py@47
[4]https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1030-L1037

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/705760

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/705982

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.opendev.org/705903
Reason: https://review.opendev.org/#/c/705760/ is almost merged. This patch makes no sense now.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705760
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=eef658bf5354e1a47b742851c29a1479c9aebcf8
Submitter: Zuul
Branch: master

commit eef658bf5354e1a47b742851c29a1479c9aebcf8
Author: Stephen Finucane <email address hidden>
Date: Tue Feb 4 15:44:54 2020 +0000

    Handle neutron without the fip-port-details extension

    The 'fip-port-details' API extension was added to neutron in Rocky [1]
    and is optional. As a result, we cannot rely on the 'port_details' field
    being present in API responses. If it is not, we need to make a second
    query for all ports and build 'port_details' using the 'port_id' field.

    [1] https://docs.openstack.org/releasenotes/neutron-lib/rocky.html#relnotes-1-14-0-stable-rocky-new-features

    Change-Id: Ifb96f31f471cc0a25c1dfce2161a669b97a384ae
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-bug: #1861876

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/706213

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706213
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=aec3ca0765e85a8bb619cd38b5411a4fbc0acaf3
Submitter: Zuul
Branch: master

commit aec3ca0765e85a8bb619cd38b5411a4fbc0acaf3
Author: Stephen Finucane <email address hidden>
Date: Thu Feb 6 10:04:24 2020 +0000

    Don't error out on floating IPs without associated ports

    Floating IPs don't have to have an associated port, so there's no reason
    to error out when this is the case.

    Change-Id: I50c79843bf819b731c597dbfe72090cdf02c7641
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-bug: #1861876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705903
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5b12d808aa3255a595bc2f8ee01411819b5b72f3
Submitter: Zuul
Branch: master

commit 5b12d808aa3255a595bc2f8ee01411819b5b72f3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Feb 5 09:30:43 2020 +0000

    Disable neutron-ovn-tempest-ovs-release temporarily

    Until LP 1861876 is solved.

    Change-Id: I344b413fa70cab79738684f4315ba7d0886edce8
    Related-Bug: #1861876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705982
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=50025935fec858138becf00640dc3ee1de508812
Submitter: Zuul
Branch: master

commit 50025935fec858138becf00640dc3ee1de508812
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Feb 5 15:16:30 2020 +0000

    Add 'fip-port-details' to OVN ML2 supported extensions

    This extension will add information about the attached port in the
    floating IP dictionary.

    This extension is not mandatory but very handy because sometime this
    extra information avoids to make a second call to Neutron.

    Related-Bug: #1861876

    Change-Id: I0175a2d00256e6d904cbcf25ad4a08aa825a9e18