Reviewed:  https://review.opendev.org/712751
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=930bf0ae1be07744183c40c6a20d0518a352947f
Submitter: Zuul
Branch:    stable/rocky

commit 930bf0ae1be07744183c40c6a20d0518a352947f
Author: Balazs Gibizer <email address hidden>
Date:   Wed May 1 23:06:52 2019 +0200

    Remove global state from the FakeDriver
    
    The virt driver FakeDriver used in both the functional and in the unit
    test used a global state to configure the host and node names the driver
    reports. This was hard to use when more then one compute service is started.
    Also global state is dangerous.
    
    It turned out that only a set of unit tests are using multiple nodes per
    compute the rest of the tests can simply use host=<hostname>,
    nodes=[<hostname>] setup.
    
    So this removes the global state.
    
    Conflicts:
        nova/tests/functional/compute/test_live_migration.py
        nova/tests/functional/integrated_helpers.py
        nova/tests/functional/regressions/test_bug_1671648.py
        nova/tests/functional/regressions/test_bug_1702454.py
        nova/tests/functional/regressions/test_bug_1718455.py
        nova/tests/functional/regressions/test_bug_1718512.py
        nova/tests/functional/regressions/test_bug_1719730.py
        nova/tests/functional/regressions/test_bug_1735407.py
        nova/tests/functional/regressions/test_bug_1741307.py
        nova/tests/functional/regressions/test_bug_1746483.py
        nova/tests/functional/regressions/test_bug_1764883.py
        nova/tests/functional/regressions/test_bug_1781710.py
        nova/tests/functional/regressions/test_bug_1784353.py
        nova/tests/functional/regressions/test_bug_1797580.py
        nova/tests/functional/test_aggregates.py
        nova/tests/functional/test_server_group.py
        nova/tests/functional/test_servers.py
        nova/tests/unit/compute/test_compute_mgr.py
    
    Note(elod.illes): cause of conflicts of the files:
    * test_live_migration.py:
        Patch Icb0bdaf454935b3713c35339394d260b33520de5 had to be
        refactored during backport to Rocky as uuidsentinel moved to oslo
        in Stein.
    * integrated_helpers.py:
        Patches I4c12502c86c7ac27369d119e0f97768cf41695b5 and
        I7f5f08691ca3f73073c66c29dddb996fb2c2b266 were only added in Stein.
    * test_bug_1671648.py, test_bug_1702454.py, test_bug_1718455.py,
      test_bug_1718512.py, test_bug_1719730.py, test_bug_1735407.py,
      test_bug_1741307.py, test_bug_1746483.py, test_bug_1764883.py,
      test_bug_1781710.py, test_bug_1784353.py, test_bug_1797580.py,
      test_servers.py:
        Duplicate cleanup removal patch
        Iaae6fc4a66145576f4a4fc1cea452ef6acbadb15 is not backported to
        Rocky.
    * test_aggregates.py:
        Patches Ic55b88e7ad21ab5b7ad063eac743ff9406aae559 and
        Ic55b88e7ad21ab5b7ad063eac743ff9406aae559 were not backported to
        Rocky.
    * test_server_group.py:
        Iaae6fc4a66145576f4a4fc1cea452ef6acbadb15 (Duplicate cleanup
        removal) and Ie07b419732e0832a9b9d16565f6c9d00ba85d654 (Add
        functional test for live migrate with anti-affinity group) patches
        were only added in Stein and were not backported to Rocky.
    * test_compute_mgr.py:
        Patch I17543ecb572934ecc7d0bbc7a4ad2f537fa499bc (Raise
        InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize)
        isn't backported to Rocky.
    
    Related-Bug: #1859766
    
    Change-Id: I2cf2fcbaebc706f897ce5dfbff47d32117064f9c
    (cherry picked from commit b5666fb49239dbed6777481be63276db35ed8118)
    (cherry picked from commit 23d3b8fbc9d793b4faba472ec6a0f7b95be1e70f)