Nova not creating the "create" action in cell0

[Brin Zhang]

Setup
-----

1. Disable single nova-compute service as admin.
2. Switch to non-admin demo user/project.

Create Test
-----------

1. Create server which fails with NoValidHost.
2. Show the server fault details as the non-admin user:

$ openstack server show build-fail1 -f value -c fault
{u'message': u'No valid host was found. ', u'code': 500, u'created': u'2019-11-13T15:57:13Z'}

Instance actions
----------------

Actual result
=============
1. As admin:

$ nova instance-action-list 008a7d52-dd83-4f52-a720-b3cfcc498259
+--------+------------+---------+------------+------------+
| Action | Request_ID | Message | Start_Time | Updated_At |
+--------+------------+---------+------------+------------+
+--------+------------+---------+------------+------------+

2. As demo user/project (owner of the server):

$ nova instance-action-list 008a7d52-dd83-4f52-a720-b3cfcc498259
+--------+------------+---------+------------+------------+
| Action | Request_ID | Message | Start_Time | Updated_At |
+--------+------------+---------+------------+------------+
+--------+------------+---------+------------+------------+

Expected result
===============
When the instance is not creating, the "create" action should be recorded in cell0.

Since the instance is in cell0 the "create" action is not there.
It only gets created in the non-cell0 cell that the instance is created in:

https://github.com/openstack/nova/blob/20.0.0/nova/conductor/manager.py#L1460

Back in Mitaka the API would create the "create" action before
casting to conductor:

https://github.com/openstack/nova/blob/mitaka-eol/nova/compute/api.py#L1180

[Matt Riedemann (mriedem)]

I already have a fix for this: https://review.opendev.org/#/c/694165/