rng is only enabled if qemu guest agent is enabled
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Invalid
|
Medium
|
sean mooney |
Bug Description
In change https:/
the libvirt xml generation was refactored to reduce code complexity.
while this was inteded to have no fucntional change it unintentionally change when the random number generator woudl be enabled
has a miss placed comment that the contence of the if block only applied to the qemu guest agent
# Qemu guest agent only support 'qemu' and 'kvm' hypervisor
if CONF.libvirt.
...
the if is instead gurading so that the block actully run only when qemu and kvm is used and the body
of the if has code for both the qemu guest agent and the random number generator
in the refactor the code to add the rng was added to the code for adding the qemu guest agent and as a result it would only be added if botht the rng and qemu guest agent are both enabled.
i miss read the indentation guest_agent
_add_rng_device was only called form _set_qemu_
but it was called uncondtionally as was _set_qemu_ guest_agent
so it actully was working just hard to follow