Check UEFI support not insufficient

Bug #1845628 reported by Dongcan Ye
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Dongcan Ye

Bug Description

Now, delete instance, swap volume and snapshot, we always clear NVRAM flags.
This is not right, currently we only check the host support uefi booting for guests from "_has_uefi_support".
If an instance not boot with UEFI but the host enable UEFI, we also needs to clear NVRAM flags in guest delete_configuration.

IMO, we need to check the instance(guest) and host support UEFI both, like check the instance's image_meta.

Dongcan Ye (hellochosen)
Changed in nova:
assignee: nobody → Dongcan Ye (hellochosen)
Revision history for this message
Matt Riedemann (mriedem) wrote :

Looks like a duplicate of https://review.opendev.org/#/c/621646/.

Revision history for this message
Dongcan Ye (hellochosen) wrote :

No, I think they are different.
The problem of this bug is that support_uefi only check the host supported, not the guest.
If an instance boot with legacy BIOS, we should not excute L267-L271 in [1].

[1] https://review.opendev.org/#/c/621646/28/nova/virt/libvirt/guest.py

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/685678

Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/685678
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9ae4d9274e3e310fdd04c81e92e9c4803c434fff
Submitter: Zuul
Branch: master

commit 9ae4d9274e3e310fdd04c81e92e9c4803c434fff
Author: Dongcan Ye <email address hidden>
Date: Mon Sep 30 10:36:01 2019 +0000

    libvirt: Check the guest support UEFI

    commit 539d381434ccadcdc3f5d58c2705c35558a3a065 add a
    NVRAM flag in guest delete_configuration, but check
    UEFI support only in host side. If an instance does
    not boot from UEFI, but the host enable UEFI software
    like OVMF, the NVRAM flag always delete.

    This patch also check the guest support UEFI.

    Change-Id: I3448b89f58f3c3a85d15ee5a870c24b4b7f201df
    Closes-Bug: #1845628

Changed in nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.