nonexistent hacking rules descriptions in HACKING.rst

Bug #1841400 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Takashi Natsume

Bug Description

N321, N328, N329, N330 hacking rules have been removed, but the descriptions are still in HACKING.rst.
The rule number N307 is missing in HACKING.rst.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/678462

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/678462
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=97a5f0e216ad02bd9ba805436a1b553c3dacf6d2
Submitter: Zuul
Branch: master

commit 97a5f0e216ad02bd9ba805436a1b553c3dacf6d2
Author: Takashi NATSUME <email address hidden>
Date: Mon Aug 26 13:19:08 2019 +0900

    Remove descriptions of nonexistent hacking rules

    N321, N328, N329, N330 hacking rules have been removed
    since I9c334162fe1799e7b24563fdc11256b91bbafc9f.
    However the descriptions are still in HACKING.rst.
    So remove them.
    The rule number N307 is missing in HACKING.rst.
    So add it.

    Change-Id: I868c421a0f5a3329ab36f786f8519accae623f1a
    Closes-Bug: #1841400

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/679695

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/679695
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b6c3ff6c77a8e40c616477ee2cff9f7e17a29d5c
Submitter: Zuul
Branch: stable/stein

commit b6c3ff6c77a8e40c616477ee2cff9f7e17a29d5c
Author: Takashi NATSUME <email address hidden>
Date: Mon Aug 26 13:19:08 2019 +0900

    Remove descriptions of nonexistent hacking rules

    N321, N328, N329, N330 hacking rules have been removed
    since I9c334162fe1799e7b24563fdc11256b91bbafc9f.
    However the descriptions are still in HACKING.rst.
    So remove them.
    The rule number N307 is missing in HACKING.rst.
    So add it.

    Change-Id: I868c421a0f5a3329ab36f786f8519accae623f1a
    Closes-Bug: #1841400
    (cherry picked from commit 97a5f0e216ad02bd9ba805436a1b553c3dacf6d2)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.3

This issue was fixed in the openstack/nova 19.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.