lxml 4.4.0 causes failed tests in nova

[Matthew Thode]

It looks like it's just a ordering issue for the elements that are returned.

See https://review.opendev.org/673848 for details on the failure (you can depend on it for testing fixes as well).

[Matthew Thode (prometheanfire)]

might be fixed in 4.4.1

https://github.com/lxml/lxml/compare/lxml-4.4.0...lxml-4.4.1

[Matthew Thode (prometheanfire)]

doesn't look like it.

[Matt Riedemann (mriedem)]

Bug 1841667 has an example of the failed tests as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/678964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678964
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=58ffff49ac716772b8d67ab487938215f5a0a658
Submitter: Zuul
Branch: master

commit 58ffff49ac716772b8d67ab487938215f5a0a658
Author: Sean Mooney <email address hidden>
Date: Tue Aug 27 23:16:38 2019 +0100

    fix lxml compatibility issues

    Some unit tests were performing string matches on xml data
    with inputs that were generated using lxml. This is problematic
    as while white space between element tags is important in xml
    ordering of attributes within a tag is not. In the latest version
    of lxml the ordering asserted in the test no longer matches the
    order returned by lxml on python 3.6+.

    This change updates the failing test to use the XMLMatcher
    class to compare xml strings instead.

    Closes-Bug: #1838666
    Related-Bug: #1841667
    Change-Id: I1649a850ccb9ac85d7a962936ffef51d573b6f78

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.