Quota legacy method warning logged even without CONF.quota.count_usage_from_placement=True

[melanie witt]

The following warning is being logged even when CONF.quota.count_usage_from_placement is not set to True:

Jun 17 18:10:23.399734 ubuntu-bionic-rax-dfw-0007867224 <email address hidden>[9186]: WARNING nova.quota [None req-3ba6d21b-40e4-47bb-8d38-ae2647245cbd None None] Falling back to legacy quota counting method for instances, cores, and ram

This is not correct and results in constant warnings being logged for users who have not opted-in to counting quota usage from placement.

Example from a gate run:

http://logs.openstack.org/67/652967/6/check/tempest-full-py3/02860e1/controller/logs/screen-n-api.txt.gz#_Jun_17_18_10_23_399734

The message is logged 186 times in the file ^ when CONF.quota.count_usage_from_placement = False.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665765
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=818c31f96e773a47a6fcbf084e13933865fdac80
Submitter: Zuul
Branch: master

commit 818c31f96e773a47a6fcbf084e13933865fdac80
Author: melanie witt <email address hidden>
Date: Mon Jun 17 21:21:27 2019 +0000

    Log quota legacy method warning only if counting from placement

    The log warning message is being emitted unconditionally and should be
    limited to only when CONF.quota.count_usage_from_placement = True.

    This fixes the issue and adds missing unit test coverage that would
    have caught it.

    Closes-Bug: #1833130

    Change-Id: I00ee0bd99c4f31a2b73fc69373fefb56740f5425

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.