OpenStack Compute (nova)

Wrong assert methods in unit tests

Bug #1827984 reported by Takashi Natsume on 2019-05-07

This bug affects 1 person

	Status	Importance	Assigned to
OpenStack Compute (nova)	Fix Released	Undecided	Takashi Natsume
Rocky	Fix Committed	Undecided	Takashi Natsume
Stein	Fix Committed	Undecided	Takashi Natsume

Bug Description

There are some wrong assert methods in nova/tests/unit/compute/test_compute_mgr.py.
They should be fixed.

https://opendev.org/openstack/nova/src/commit/517031b82c7ae22c842623cdb7bd04fdd3280f29/nova/tests/unit/compute/test_compute_mgr.py#L6174
https://opendev.org/openstack/nova/src/commit/517031b82c7ae22c842623cdb7bd04fdd3280f29/nova/tests/unit/compute/test_compute_mgr.py#L8119

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-05-07: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/657525

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-05-07: Fix merged to nova (master)

Reviewed: https://review.opendev.org/657525
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3c411febf8b67f93cf16e639aed043f7312f9577
Submitter: Zuul
Branch: master

commit 3c411febf8b67f93cf16e639aed043f7312f9577
Author: Takashi NATSUME <email address hidden>
Date: Tue May 7 13:38:05 2019 +0900

Fix assert methods in unit tests

Change-Id: I9d77ee9007965285261362e7170114455b3bf29a
Closes-Bug: #1827984

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-05-08: Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/657708

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-05-08: Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/657709

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-05-22: Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/657708
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d250834734ea04ee202a8fee59abdca79aef8128
Submitter: Zuul
Branch: stable/stein

commit d250834734ea04ee202a8fee59abdca79aef8128
Author: Takashi NATSUME <email address hidden>
Date: Tue May 7 13:38:05 2019 +0900

Fix assert methods in unit tests

Conflicts:
nova/tests/unit/compute/test_compute_mgr.py

The conflict is due to not including
I734cc01dce13f9e75a16639faf890ddb1661b7eb in stable/stein.

    Change-Id: I9d77ee9007965285261362e7170114455b3bf29a
    Closes-Bug: #1827984
    (cherry picked from commit 3c411febf8b67f93cf16e639aed043f7312f9577)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-05-27: Fix merged to nova (stable/rocky)

Reviewed: https://review.opendev.org/657709
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6310cdd27ce8d5c34e17778bf5fddbce359f26a7
Submitter: Zuul
Branch: stable/rocky

commit 6310cdd27ce8d5c34e17778bf5fddbce359f26a7
Author: Takashi NATSUME <email address hidden>
Date: Tue May 7 13:38:05 2019 +0900

Fix assert methods in unit tests

    Change-Id: I9d77ee9007965285261362e7170114455b3bf29a
    Closes-Bug: #1827984
    (cherry picked from commit 3c411febf8b67f93cf16e639aed043f7312f9577)
    (cherry picked from commit d250834734ea04ee202a8fee59abdca79aef8128)