unnecessary placement call to fill group mapping during boot

Bug #1819430 reported by Balazs Gibizer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Matt Riedemann

Bug Description

To fill the request group - resource provider mapping nova needs to look at the allocation that is made in placement as well as the traits of the used providers. These are explicit placement calls today. However it turns out that the Selection object already contains the allocation data so one of the extra placement call can be removed. This change can lead to a bit better performance.

Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :
Changed in nova:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
importance: Undecided → Low
status: New → In Progress
tags: added: conductor
tags: added: performance
Changed in nova:
assignee: Balazs Gibizer (balazs-gibizer) → Matt Riedemann (mriedem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/638711
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1a89c1d73b8230e437ed0e15656a2606a94926f8
Submitter: Zuul
Branch: master

commit 1a89c1d73b8230e437ed0e15656a2606a94926f8
Author: Balazs Gibizer <email address hidden>
Date: Fri Feb 22 11:34:31 2019 +0100

    Use Selection object to fill request group mapping

    To fill the request group - resource provider mapping nova needs to look
    at the allocation that is made in placement as well as the traits of
    the used providers. So far these were explicit placement calls. However
    it turns out that the Selection object already contains the allocation
    data so one of the extra placement calls can be removed.

    This patch replaces the GET /allocations/<uuid> placement call from
    conductor build instance codepath with the usage of the
    Selection.allocation_request json blob.

    Closes-Bug: #1819430

    Change-Id: Iecbee518444bd282ce5f6fd019db41a322f76a83

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.openstack.org/647713

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.openstack.org/647713
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a98fb711b58ed39ea8676cb01409562fb06f2a13
Submitter: Zuul
Branch: stable/stein

commit a98fb711b58ed39ea8676cb01409562fb06f2a13
Author: Balazs Gibizer <email address hidden>
Date: Fri Feb 22 11:34:31 2019 +0100

    Use Selection object to fill request group mapping

    To fill the request group - resource provider mapping nova needs to look
    at the allocation that is made in placement as well as the traits of
    the used providers. So far these were explicit placement calls. However
    it turns out that the Selection object already contains the allocation
    data so one of the extra placement calls can be removed.

    This patch replaces the GET /allocations/<uuid> placement call from
    conductor build instance codepath with the usage of the
    Selection.allocation_request json blob.

    Closes-Bug: #1819430

    Change-Id: Iecbee518444bd282ce5f6fd019db41a322f76a83
    (cherry picked from commit 1a89c1d73b8230e437ed0e15656a2606a94926f8)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.1

This issue was fixed in the openstack/nova 19.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.