GET /servers/{server_id} response for a down-cell instance does not include links

[Matt Riedemann]

The down-cell microversion 2.69 just recently merged and returns links in the response for GET /servers/detail but not GET /servers/{server_id} (show) which was an oversight because that API returns links normally:

https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details

We should include the links in the 'show' case as well and make sure to update the docs in the compute API guide:

https://developer.openstack.org/api-guide/compute/down_cells.html

https://review.openstack.org/#/c/621474/28/nova/api/openstack/compute/views/servers.py@180

Typically this would require a microversion change but given the code merged on Feb 15 (https://review.openstack.org/#/c/635146/) and is not yet released I think we can bend the microversion rules and just fix this oversight since I doubt anyone has deployed or is using this yet since it's a pretty advanced use case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/640302

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/640302
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a0b1951d2ad2195c26d7f372c54837f6f88fe1f9
Submitter: Zuul
Branch: master

commit a0b1951d2ad2195c26d7f372c54837f6f88fe1f9
Author: Surya Seetharaman <email address hidden>
Date: Fri Mar 1 10:58:26 2019 +0100

    Add "links" in the response of "nova show" for a down-cell instance

    The down-cell microversion 2.69 just recently merged and it returns
    links in the response for GET /servers/detail and GET /servers but not
    for GET /servers/{server_id} which was an oversight because that API
    returns links normally.

    We should include the links key in the 'nova show' case as well and this
    patch does exactly that.

    Typically this would require a microversion change but given the code
    merged recently and is not yet released we are just fixing this
    oversight through this patch without a microversion bump.

    Closes-Bug: #1818131
    Change-Id: I2ce03df994f59c37b5ce3102c4e7165d17701798

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.