nova-compute driver type has been changed from 'ironic' to 'libvirted', the nova-compute sevice is still can get by 'ironic' conpute_driver type

[lynn]

Description
===========
the cloud has 2 nova-compute service and both of their compute_driver is ironic. then changed one nova-compute service to libvirt.

when add more bm-nodes to the cloud,but some bm-nodes didn't show up in the hypervisor list

in the nova/virt/ironic/driver.py, the ironic driver has hash_ring of compute_services which are ironic type,
the hash_ring get the ironic type compute_services with the method of service_get_all_computes_by_hv_type(nova/db/sqlalchemy/api.py). The method get the services which have been deleted due to the nova compute services have been changed types of compute_driver with old host name can still be queried by old type

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/637083

[Zhenyu Zheng (zhengzhenyu)]

I think your title and your content doesn't match, your title says, ``can still get`` seems to me
that you can get extra records that the old type is ``ironic``, but your content seems describes
the case that some of them is missing.

[lynn (lynn901)]

@ Zhenyu Zheng
thanks for your attention, i have update bug title and content.
hope to help you understand what i mention

[lynn (lynn901)]

@ Zhenyu Zheng
the following is my truble shoot

https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py
> def _refresh_hash_ring(self, ctxt):
> service_list = objects.ServiceList.get_all_computes_by_hv_type(ctxt, self._get_hypervisor_type())

https://github.com/openstack/nova/blob/master/nova/objects/service.py
>> def get_all_computes_by_hv_type(cls, context, hv_type):
      db_services = db.service_get_all_computes_by_hv_type(context, hv_type, include_disabled=False)

https://github.com/openstack/nova/blob/master/nova/db/api.py
>>> def service_get_all_computes_by_hv_type(context, hv_type, include_disabled=False):
           return IMPL.service_get_all_computes_by_hv_type(context, hv_type, include_disabled=include_disabled)

https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py
>>>> def service_get_all_computes_by_hv_type(context, hv_type,
                                        include_disabled=False):
    query = model_query(context, models.Service, read_deleted="no").\
                    filter_by(binary='nova-compute')
    if not include_disabled:
        query = query.filter_by(disabled=False)
    query = query.join(models.ComputeNode,
                       models.Service.host == models.ComputeNode.host).\
                  filter(models.ComputeNode.hypervisor_type == hv_type).\
                  distinct('host')
    return query.all()

[OpenStack Infra (hudson-openstack)]

Change abandoned by Stephen Finucane (<email address hidden>) on branch: master
Review: https://review.opendev.org/637083