A new instance_mapping record will have queued_for_delete set to NULL

[Surya Seetharaman]

After this change: https://review.openstack.org/#/c/584504, where we changed the default value of queued_for_delete column from False to NULL in the sqla code for the instance_mappings object (to do the data migration for queued_for_delete), we forgot to set the default value as False upon creation of the new instance_mappings in the create() method. Hence new instance_mappings always ended up with NULL values in the db meaning the data migration "populate_queued_for_delete" would never finish.

So in the InstanceMapping.create() function queued_for_delete should always be set to False() explicitly so that new mappings get False as the default value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/635185

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/635185
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ccec9ba82de7c9525981a34bb126e9ca98042d04
Submitter: Zuul
Branch: master

commit ccec9ba82de7c9525981a34bb126e9ca98042d04
Author: Dan Smith <email address hidden>
Date: Wed Feb 6 06:54:00 2019 -0800

    Fix InstanceMapping to always default queued_for_delete=False

    This object has a default=False setting for queued_for_delete, but never
    actually sets that value. All newly created records should have a non-NULL
    value for this field, and we have a migration to fix them, so this
    change explicitly forces that =False, unless the object is being created
    with a value set.

    Closes-Bug: #1814913
    Change-Id: I99c5cc24c7e9bf5e2e72ffc868990b87b0e8e3f8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/635534

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/635534
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cb65d3d69c2b36a1a18d3fe4347b445f17f6d856
Submitter: Zuul
Branch: stable/rocky

commit cb65d3d69c2b36a1a18d3fe4347b445f17f6d856
Author: Dan Smith <email address hidden>
Date: Wed Feb 6 06:54:00 2019 -0800

    Fix InstanceMapping to always default queued_for_delete=False

    This object has a default=False setting for queued_for_delete, but never
    actually sets that value. All newly created records should have a non-NULL
    value for this field, and we have a migration to fix them, so this
    change explicitly forces that =False, unless the object is being created
    with a value set.

    Closes-Bug: #1814913
    Change-Id: I99c5cc24c7e9bf5e2e72ffc868990b87b0e8e3f8
    (cherry picked from commit ccec9ba82de7c9525981a34bb126e9ca98042d04)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.2.0 release.